>From Murtadha Hubail <mhub...@apache.org>: Attention is currently required from: preetha...@apache.org. Murtadha Hubail has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19745 )
Change subject: [ASTERIXDB-3392] Improve logging on copy to parquet ...................................................................... Patch Set 2: (4 comments) File asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/parquet/ParquetSchemaInferPoolWriter.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19745/comment/25cf5f83_e4423ecc PS2, Line 72: .M space https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19745/comment/5e3bc1ae_48eb82f7 PS2, Line 74: S Please review the capitalization in the newly added logs. There is no need to make words capitalized in the middle of the logged statements as this makes such words standout unnecessarily while debugging and it interrupts the flow of reading the logs. Some prefer to make all logs in lower case. File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/writer/printer/parquet/ParquetRecordLazyVisitor.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19745/comment/3582a18e_14606945 PS2, Line 79: + LogRedactionUtil.userData(type.toString()) + use place holders in all new logs messages File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/writer/printer/parquet/ParquetSchemaLazyVisitor.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19745/comment/de0654fc_0f04187a PS2, Line 149: Building Parquet Schema: how often will this be logged? -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19745 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: ionic Gerrit-Change-Id: I93c6e8d9d6eed4e42ea5419a444b7aaee348965b Gerrit-Change-Number: 19745 Gerrit-PatchSet: 2 Gerrit-Owner: preetha...@apache.org Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Murtadha Hubail <mhub...@apache.org> Gerrit-Reviewer: preetha...@apache.org Gerrit-Attention: preetha...@apache.org Gerrit-Comment-Date: Mon, 12 May 2025 14:14:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
