>From Ritik Raj <ritik....@couchbase.com>: Attention is currently required from: Peeyush Gupta, Wail Alkowaileet. Ritik Raj has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19944 )
Change subject: [ASTERIXDB-3601][STO] Supporting multi-page zeroes ...................................................................... Patch Set 8: (4 comments) File asterixdb/asterix-column/src/main/java/org/apache/asterix/column/zero/writers/multipage/SparseColumnMultiPageZeroReader.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19944/comment/e81d691d_bdf27353 PS7, Line 291: numberOfColumnInZerothSegment > Shouldn't it be numberOfPageZeroSegments? In SparseColumnMultiPageZeroWriter. > […] Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19944/comment/9d4df6da_3ace8f5a PS7, Line 316: numberOfColumnInZerothSegment > see the previous comment. Done File asterixdb/asterix-column/src/main/java/org/apache/asterix/column/zero/writers/multipage/SparseColumnMultiPageZeroWriter.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19944/comment/c1372a97_b9d64af1 PS7, Line 113: numberOfColumnInZerothSegment > shouldn't this be numberOfPageZeroSegments? numberOfColumnInZerothSegment > could be a large value and […] Done File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree-column/src/main/java/org/apache/hyracks/storage/am/lsm/btree/column/impls/lsm/tuples/ColumnMultiBufferProvider.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19944/comment/043ca1bf_c753d223 PS7, Line 124: } catch (Exception e) { : throw e; : } > Were you planning to add some logic/logging here? If not we can remove this > try and catch. Done -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19944 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: ionic Gerrit-Change-Id: I8e54f0e6a8cb9f17a38394833f1c8990ce29676e Gerrit-Change-Number: 19944 Gerrit-PatchSet: 8 Gerrit-Owner: Ritik Raj <ritik....@couchbase.com> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Peeyush Gupta <peeyush.gu...@couchbase.com> Gerrit-CC: Wail Alkowaileet <wael....@gmail.com> Gerrit-Attention: Peeyush Gupta <peeyush.gu...@couchbase.com> Gerrit-Attention: Wail Alkowaileet <wael....@gmail.com> Gerrit-Comment-Date: Mon, 23 Jun 2025 21:54:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Peeyush Gupta <peeyush.gu...@couchbase.com> Gerrit-MessageType: comment
