>From Peeyush Gupta <[email protected]>: Attention is currently required from: Ali Alsuliman, Michael Blow. Peeyush Gupta has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19984 )
Change subject: [NO ISSUE][EXT] Query fails on GCS external delta table ...................................................................... Patch Set 3: Code-Review+1 (1 comment) Patchset: PS3: > +2ed, but why would this change fix the NPE issue? What was causing it in the > first place? The NPE was cause due to https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19444. That change added the following line in GCSDeltaReaderFactory.configureJobConf int numberOfPartitions = getPartitionConstraint().getLocations().length; getPartitionConstraint in DeltaReaderFactory only gets the partitionsConstraints and does not set if null. With this change I moved the computation of partition constraints before configureJobConf is called to avoid NPE. -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19984 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: ionic Gerrit-Change-Id: Ibd700a0c4e740139630869d98ce7cf52389ea5cf Gerrit-Change-Number: 19984 Gerrit-PatchSet: 3 Gerrit-Owner: Peeyush Gupta <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Peeyush Gupta <[email protected]> Gerrit-Attention: Ali Alsuliman <[email protected]> Gerrit-Attention: Michael Blow <[email protected]> Gerrit-Comment-Date: Mon, 30 Jun 2025 14:57:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Hussain Towaileb <[email protected]> Gerrit-MessageType: comment
