>From Ali Alsuliman <[email protected]>:

Attention is currently required from: Ritik Raj.
Ali Alsuliman has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20014 )

Change subject: [NO ISSUE][COMP] Restricting pushdown for array functions
......................................................................


Patch Set 5:

(3 comments)

File 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/pushdown/processor/AbstractFilterPushdownProcessor.java:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20014/comment/25d1f1a4_e511cac8
PS5, Line 360: isExpressionReturningArray
Change the name to match the returned values.


File 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/pushdown/processor/ColumnFilterPushdownProcessor.java:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20014/comment/3dc7b334_33ce7721
PS5, Line 132: isExpressionReturningArray
Make sure this is negated or not negated if you change the name.


https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20014/comment/99363dba_3db6f8bf
PS5, Line 137: FilterBranch.FILTER_PATH
This should be COMPARE.



--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20014
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: ionic
Gerrit-Change-Id: Ib3a4aa0715cf3b2fc0a1882d8b5114e88d0004f3
Gerrit-Change-Number: 20014
Gerrit-PatchSet: 5
Gerrit-Owner: Ritik Raj <[email protected]>
Gerrit-Reviewer: Ali Alsuliman <[email protected]>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Reviewer: Peeyush Gupta <[email protected]>
Gerrit-Attention: Ritik Raj <[email protected]>
Gerrit-Comment-Date: Mon, 07 Jul 2025 16:58:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Reply via email to