>From Peeyush Gupta <[email protected]>: Attention is currently required from: Ritik Raj. Peeyush Gupta has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20016 )
Change subject: [ASTERIXDB-3601][STO] Unpinning the not required segmentPages ...................................................................... Patch Set 3: Code-Review+2 (5 comments) Patchset: PS3: Please check the comments, most of them are questions only? File asterixdb/asterix-app/pom.xml: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20016/comment/1e0caa87_7605ed3f PS3, Line 494: CloudStorageSparseTest Do you need to include the complete CloudStorageSparseTest.java here? File asterixdb/asterix-column/src/main/java/org/apache/asterix/column/zero/PageZeroWriterFlavorSelector.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20016/comment/46b1d5e2_b05fe19a PS3, Line 53: DEFAULT Any particular reason for this change? File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree-column/src/main/java/org/apache/hyracks/storage/am/lsm/btree/column/cloud/ColumnRanges.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20016/comment/b8312010_f974bfd1 PS3, Line 171: leafFrame.unPinNotRequiredPageZeroSegments(); Can explicit unpinning here cause any issues when a query is running concurrenlty? File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree-column/src/main/java/org/apache/hyracks/storage/am/lsm/btree/column/cloud/buffercache/read/CloudColumnReadContext.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20016/comment/ebb096ae_49e31826 PS3, Line 141: // mergedPageRanges.clear(); remove commented out code -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20016 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: ionic Gerrit-Change-Id: I915031e39a17ac853a24d78809b7742e2ea60163 Gerrit-Change-Number: 20016 Gerrit-PatchSet: 3 Gerrit-Owner: Ritik Raj <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Peeyush Gupta <[email protected]> Gerrit-Attention: Ritik Raj <[email protected]> Gerrit-Comment-Date: Mon, 07 Jul 2025 18:56:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
