>From Peeyush Gupta <peeyush.gu...@couchbase.com>: Attention is currently required from: Ali Alsuliman. Peeyush Gupta has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20010 )
Change subject: [NO ISSUE][COMP] Remove check-unknown for Insert/Upsert on datasets with meta part ...................................................................... Patch Set 2: (2 comments) File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceDynamicTypeCastRule.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20010/comment/fb97b793_d053584b PS1, Line 169: op instanceof InsertDeleteUpsertOperator > Typically, we use getOperatorTag() == LogicalOperatorTag. […] Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20010/comment/4a104f37_2c655138 PS1, Line 172: checkUnknown = false; > Just checking; there are other paths similar to this: […] IntroduceAutogenerateIDRule is not applicable in case of both remote or kafka linked collections as autogenerated id is not supported for them. IntroduceStaticTypeCastForInsertRule Is also not triggered because of the subplan as there is not assign record-constructor(...) outside of the subplan. -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20010 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: ionic Gerrit-Change-Id: I55766c9a334f40efd996e2b453f7237aec739966 Gerrit-Change-Number: 20010 Gerrit-PatchSet: 2 Gerrit-Owner: Peeyush Gupta <peeyush.gu...@couchbase.com> Gerrit-Reviewer: Ali Alsuliman <ali.al.solai...@gmail.com> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Peeyush Gupta <peeyush.gu...@couchbase.com> Gerrit-Attention: Ali Alsuliman <ali.al.solai...@gmail.com> Gerrit-Comment-Date: Mon, 14 Jul 2025 20:19:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Ali Alsuliman <ali.al.solai...@gmail.com> Gerrit-MessageType: comment
