>From Shahrzad Shirazi <shaji...@ucr.edu>: Attention is currently required from: Ali Alsuliman. Shahrzad Shirazi has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20004 )
Change subject: [NO ISSUE][COMP] Change plan to show RETAIN-UNTRUE for null placeholders ...................................................................... Patch Set 9: (6 comments) File hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/prettyprint/LogicalOperatorPrettyPrintVisitorJson.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20004/comment/6c70e6c7_a5772a52 PS7, Line 786: Object > Use IAlgebricksConstantValue Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20004/comment/96d48784_1d300d4a PS7, Line 787: jsonGenerator.writeObjectFieldStart("retain-missing"); > Remove this Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20004/comment/f4784c14_1933fd8d PS7, Line 790: placeholder > Make this "retain-untrue-variable" Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20004/comment/f86516cb_8cc73d02 PS7, Line 792: if (retainValue != null) { > Remove this "if" since we know retainValue is never null here. Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20004/comment/564a59ab_cfa0cffc PS7, Line 793: value > Make this "retain-untrue-value" Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20004/comment/a7aae779_1f68986d PS7, Line 796: jsonGenerator.writeEndObject(); > Remove this Done -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20004 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: ionic Gerrit-Change-Id: I4a3af98be2cf74e837222755abfd45a075b3b257 Gerrit-Change-Number: 20004 Gerrit-PatchSet: 9 Gerrit-Owner: Shahrzad Shirazi <shaji...@ucr.edu> Gerrit-Reviewer: Ali Alsuliman <ali.al.solai...@gmail.com> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Shahrzad Shirazi <shaji...@ucr.edu> Gerrit-Attention: Ali Alsuliman <ali.al.solai...@gmail.com> Gerrit-Comment-Date: Fri, 18 Jul 2025 20:55:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Ali Alsuliman <ali.al.solai...@gmail.com> Gerrit-MessageType: comment
