>From Shahrzad Shirazi <[email protected]>: Attention is currently required from: Michael Blow, Hussain Towaileb. Shahrzad Shirazi has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20146 )
Change subject: [NO ISSUE][COMP] Add None as quote option for CSV in external collections ...................................................................... Patch Set 20: (12 comments) File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/QuotedLineRecordReader.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20146/comment/da82e232_b69e764c PS3, Line 59: CSVUtils.extractSingleChar(quoteString) > I believe this currently will be initialized the null char ('\0') when the > option none is specified, […] Done File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/QuotedLineRecordReader.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20146/comment/2b793549_1b0ff132 PS12, Line 62: this.quoteCheckNeeded = this.quote != CSVUtils.NULL_CHAR; > There is a possibility that someone has quote as '\0'. […] Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20146/comment/26d48891_5ec2f80f PS12, Line 93: public boolean hasNext() throws IOException { > What I meant is something like this: […] Done File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/DelimitedDataParser.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20146/comment/f95e7095_6a5695d1 PS18, Line 238: true > Why not use the qouteCheckNeeded passed in the constructor? Same thing for > below. Done File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataUtils.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20146/comment/65f4b8ce_96699cf3 PS12, Line 698: public static void validateChar > Got it, thanks, will change in the new patch set. Done File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataUtils.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20146/comment/bc8e0cf5_8f6de95c PS18, Line 169: checkIfQouteIsNeeded > Rename this to "isQuoteNeeded()" Done File hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/file/DelimitedDataTupleParserFactory.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20146/comment/ac1bc778_bc175247 PS18, Line 112: } > Revert those line changes, here and above. Done File hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/file/FieldCursorForDelimitedDataParser.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20146/comment/8cc40fb6_57af8517 PS12, Line 311: if (!quoteCheckNeeded || !startedQuote) { > I didn't quite follow the flow for NONE option where the quoteCheckNeeded is > false, meaning how is t […] Ack File hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/file/FieldCursorForDelimitedDataParser.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20146/comment/db416c98_9fd72c02 PS18, Line 78: //the delimiter > Keep this comment next to the fieldDelimiter as it used to be Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20146/comment/2149ed01_a1ea0a7f PS18, Line 190: > not needed extra line? Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20146/comment/49ac369e_8267cc01 PS18, Line 315: > Remove those not needed extra lines. Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20146/comment/bfc04a64_22ea704d PS18, Line 486: } > Do you have some kind of auto formatting that tries to remove trailing new > lines? No, not sure why this happens! -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20146 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: ionic Gerrit-Change-Id: I3812d2d1306282e9f02e8b77e1f79ac6b203cabe Gerrit-Change-Number: 20146 Gerrit-PatchSet: 20 Gerrit-Owner: Shahrzad Shirazi <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Attention: Michael Blow <[email protected]> Gerrit-Attention: Hussain Towaileb <[email protected]> Gerrit-Comment-Date: Thu, 14 Aug 2025 05:51:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Murtadha Hubail <[email protected]> Comment-In-Reply-To: Shahrzad Shirazi <[email protected]> Comment-In-Reply-To: Ali Alsuliman <[email protected]> Gerrit-MessageType: comment
