>From Ali Alsuliman <[email protected]>: Attention is currently required from: Shahrzad Shirazi. Ali Alsuliman has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17729 )
Change subject: [NO ISSUE][COMP] Simplify Index-only plan ...................................................................... Patch Set 43: (5 comments) Commit Message: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17729/comment/da3bc537_a1dc5d20 PS43, Line 7: NO ISSUE Create an *DB issue and use it here. Also rebase the patch. File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/IntroduceLSMComponentFilterRule.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17729/comment/5ffb1136_22859c7e PS43, Line 99: IAType filterSourceType = filterSourceIndicator == null || filterSourceIndicator == 0 We don't need to change this, right? Same thing at the very end of the file. File asterixdb/asterix-app/src/test/resources/optimizerts/results/ASTERIXDB-2402.plan: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17729/comment/8c86d645_406b88ca PS43, Line 8: [cardinality: 0.0, doc-size: 0.0, op-cost: 0.0, total-cost: 0.0] Can you remove these from all optimizerts plans? File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/runningaggregates/std/WinMarkValidTuplesRunningAggregateEvaluator.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17729/comment/32db21fb_b27812f3 PS43, Line 80: if (first) { Do it like this: boolean value; if (first) { first = false; value = true; for (int i = 0; i < args.length; i++) { args[i].evaluate(tuple, argFirstValues[i]); } } else { value = sameTuple(); } resultStorage.reset(); boolSerde.serialize(ABoolean.valueOf(value), dataOutput); result.set(resultStorage); private boolean sameTuple() throws HyracksDataException { for (int i = 0; i < args.length; i++) { IPointable v1 = argFirstValues[i]; IPointable v2 = args[i].evaluate(tuple, argCurrValues[i]); IBinaryComparator cmp = argComparators[i]; if (...) { return false; } } return true; } https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17729/comment/6390e06d_f82f239d PS43, Line 107: return false; I keep forgetting. Do we want to keep the tuple when it's different or when it's the same? -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17729 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I516dc90b8da3a7086dc80b67946a5d4f6dde0972 Gerrit-Change-Number: 17729 Gerrit-PatchSet: 43 Gerrit-Owner: Shahrzad Shirazi <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Attention: Shahrzad Shirazi <[email protected]> Gerrit-Comment-Date: Fri, 22 Aug 2025 01:35:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
