abdullah alamoudi has posted comments on this change. Change subject: Cleanup and bug fixes in Feeds pipeline ......................................................................
Patch Set 10: (5 comments) https://asterix-gerrit.ics.uci.edu/#/c/1523/10/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/MetadataProvider.java File asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/MetadataProvider.java: PS10, Line 2118: getSplitProviderAndConstraints > It looks nobody calls this? Done PS10, Line 2124: getSplitProviderAndConstraints > It looks nobody calls this? Done https://asterix-gerrit.ics.uci.edu/#/c/1523/10/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/entities/Dataset.java File asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/entities/Dataset.java: PS10, Line 594: INSTANCE > call mdProvider.findDataSourceIndex(...) instead of using the MetadataManag Done https://asterix-gerrit.ics.uci.edu/#/c/1523/10/hyracks-fullstack/hyracks/hyracks-data/hyracks-data-std/src/main/java/org/apache/hyracks/data/std/api/AbstractPointable.java File hyracks-fullstack/hyracks/hyracks-data/hyracks-data-std/src/main/java/org/apache/hyracks/data/std/api/AbstractPointable.java: PS10, Line 30: bytes > object creation. We'd better not have this method but let callers do that Done https://asterix-gerrit.ics.uci.edu/#/c/1523/10/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/api/ILSMHarness.java File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/api/ILSMHarness.java: PS10, Line 65: ctx > Document each parameter, return value, and when an exception is supposed to Done -- To view, visit https://asterix-gerrit.ics.uci.edu/1523 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie97b2133ebecb7380cf0ba336e60ed714d06f8ee Gerrit-PatchSet: 10 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
