>From Preetham Poluparthi <[email protected]>: Attention is currently required from: Murtadha Hubail. Preetham Poluparthi has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20170 )
Change subject: [NO ISSUE] Reset operators after join selectivity estimation ...................................................................... Patch Set 5: (2 comments) File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/cbo/Stats.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20170/comment/a65285a5_1e67d914 PS4, Line 257: ILogicalOperator originalLeft = abjoin.getInputs().get(0).getValue(), : originalRight = abjoin.getInputs().get(1).getValue(); > We don't usually do this for readability reasons. Just define each variable > in its own line. Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20170/comment/64b0009c_26f5fba1 PS4, Line 267: abjoin.getInputs().get(0).setValue(originalLeft); : abjoin.getInputs().get(1).setValue(originalRight); > Ideally, this should be in a finally block, unless we are failing the request > on any exception anywa […] We fail the request on exception I believe. -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20170 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: ionic Gerrit-Change-Id: Ib7c1220740c2b5f025f60bec0378eaf253533f66 Gerrit-Change-Number: 20170 Gerrit-PatchSet: 5 Gerrit-Owner: Preetham Poluparthi <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Attention: Murtadha Hubail <[email protected]> Gerrit-Comment-Date: Tue, 26 Aug 2025 09:28:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Murtadha Hubail <[email protected]> Gerrit-MessageType: comment
