Change in asterixdb[ionic]: [NO ISSUE][RT] Notify joblet cleanup if joblet creation fails

[AsterixDB Code Review]

>From Peeyush Gupta <peeyush.gu...@couchbase.com>:

Peeyush Gupta has uploaded this change for review. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20293 )


Change subject: [NO ISSUE][RT] Notify joblet cleanup if joblet creation fails
......................................................................

[NO ISSUE][RT] Notify joblet cleanup if joblet creation fails

- user model changes: no
- storage format changes: no
- interface changes: no

Ext-ref: MB-68387
Change-Id: I13ee5535269c5152a1cd923502a013fa4fad0b40
---
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/work/StartTasksWork.java
1 file changed, 23 insertions(+), 1 deletion(-)



  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/93/20293/1

diff --git 
a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/work/StartTasksWork.java
 
b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/work/StartTasksWork.java
index 410cb009..a414642 100644
--- 
a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/work/StartTasksWork.java
+++ 
b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/work/StartTasksWork.java
@@ -120,10 +120,11 @@
     public void run() {
         Task task = null;
         int taskIndex = 0;
+        Joblet joblet = null;
         try {
             ncs.updateMaxJobId(jobId);
             NCServiceContext serviceCtx = ncs.getContext();
-            Joblet joblet = getOrCreateLocalJoblet(deploymentId, serviceCtx, 
acgBytes);
+            joblet = getOrCreateLocalJoblet(deploymentId, serviceCtx, 
acgBytes);
             if (ncs.getNodeStatus() != NodeStatus.ACTIVE) {
                 throw HyracksException.create(ErrorCode.NODE_IS_NOT_ACTIVE, 
ncs.getId());
             }
@@ -206,6 +207,13 @@
             ExceptionUtils.setNodeIds(exceptions, ncs.getId());
             TaskAttemptId taskId = 
taskDescriptors.get(taskIndex).getTaskAttemptId();
             ncs.getWorkQueue().schedule(new NotifyTaskFailureWork(ncs, task, 
exceptions, jobId, taskId));
+            if (joblet == null) {
+                try {
+                    
ncs.getClusterController(jobId.getCcId()).notifyJobletCleanup(jobId, 
ncs.getId());
+                } catch (Exception ex) {
+                    LOGGER.info(e);
+                }
+            }
         }
     }


--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20293
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: ionic
Gerrit-Change-Id: I13ee5535269c5152a1cd923502a013fa4fad0b40
Gerrit-Change-Number: 20293
Gerrit-PatchSet: 1
Gerrit-Owner: Peeyush Gupta <peeyush.gu...@couchbase.com>
Gerrit-MessageType: newchange