>From Preetham Poluparthi <[email protected]>: Attention is currently required from: Ali Alsuliman.
Preetham Poluparthi has posted comments on this change by Preetham Poluparthi. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20281?usp=email ) Change subject: [ASTERIXDB-3632] Add Array Index recommendations to Index Advisor ...................................................................... Patch Set 17: (7 comments) File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/cbo/indexadvisor/AdviseIndexRule.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20281/comment/e3dd76f2_bc4f9916?usp=email : PS16, Line 149: indexAdvisor.addRecommendedAdviseString(new ValueAdvise( > If ValueAdvise and ArrayAdvise are only to be used to generate the DDL, then > there is not much value […] Done File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/cbo/indexadvisor/FakeIndex.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20281/comment/c9af4220_f5a8692b?usp=email : PS16, Line 47: List<List<String>> unnestList, List<List<String>> projectList, IAType itemType) { > Is this really a single element while projectList is a list? Done File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/cbo/indexadvisor/FakeIndexProvider.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20281/comment/0d9e72f0_0a12a125?usp=email : PS16, Line 85: continue; > There is no point in doing "continue" since if datasetIndexes == null, then > it's going to be null fo […] Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20281/comment/5f293209_89f6dcfb?usp=email : PS16, Line 94: if (unnestToProjectListMap.containsKey(unnestList)) { > I would do it like this: […] Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20281/comment/c746f3bf_861b7fa4?usp=email : PS16, Line 96: if (!arrayIndexElement.getProjectList().contains(projectList)) { > Do this if it's equivalent to what you want to do: […] No File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/cbo/indexadvisor/UnnestFilterCondition.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20281/comment/8a63091e_c301f53a?usp=email : PS16, Line 28: // private final Index.ArrayIndexElement arrayIndexElement; > Remove if not needed Done File asterixdb/asterix-app/src/test/resources/runtimets/results/cbo-join/index-advisor/array-simple-advise/array-simple-advise.6.adm: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20281/comment/85327cd0_70149e64?usp=email : PS16, Line 1: [{"#operator":"Advise","advice":{"#operator":"IndexAdvice","adviseinfo":{"current_indexes":[],"recommended_indexes":{"indexes":[{"index_statement":"CREATE INDEX array_idx_items ON `Default`.`test`.`A`(UNNEST `items` SELECT `qty`: bigint, SELECT `price`: double);"}]}}}}] > Isn't this supposed to be: […] Done -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20281?usp=email To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I9f7b70321a7ec831b4880437871af9749d93d0c4 Gerrit-Change-Number: 20281 Gerrit-PatchSet: 17 Gerrit-Owner: Preetham Poluparthi <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Attention: Ali Alsuliman <[email protected]> Gerrit-Comment-Date: Tue, 23 Sep 2025 16:43:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Ali Alsuliman <[email protected]>
