>From Ali Alsuliman <[email protected]>: Attention is currently required from: Shahrzad Shirazi.
Ali Alsuliman has posted comments on this change by Shahrzad Shirazi. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20411?usp=email ) Change subject: [NO ISSUE][COMP] Correct delivered properties of secondary index search operator ...................................................................... Patch Set 4: (2 comments) File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/physical/IndexSearchPOperator.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20411/comment/e0e22263_84642199?usp=email : PS4, Line 85: if (op.getOperatorTag() == LogicalOperatorTag.UNNEST_MAP) { Shouldn't we include LEFT_OUTER_UNNEST_MAP? Then you can downcast to AbstractUnnestMapOperator and use getScanVariables() https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20411/comment/1e2660b0_3db051c3?usp=email : PS4, Line 93: scanVariables.add(new LogicalVariable(-1)); We need to add a test for a collection that has meta record to make sure this is working fine. -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20411?usp=email To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I2812c034a6d002bf906a0dff7a26aa7402707a3f Gerrit-Change-Number: 20411 Gerrit-PatchSet: 4 Gerrit-Owner: Shahrzad Shirazi <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-CC: Ali Alsuliman <[email protected]> Gerrit-Attention: Shahrzad Shirazi <[email protected]> Gerrit-Comment-Date: Thu, 25 Sep 2025 15:59:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
