>From Ali Alsuliman <[email protected]>: Ali Alsuliman has uploaded this change for review. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20417?usp=email )
Change subject: [NO ISSUE][OTH] Extend create/drop view/synonym calls with the request parameters ...................................................................... [NO ISSUE][OTH] Extend create/drop view/synonym calls with the request parameters Ext-ref: MB-55519 Change-Id: I8134a6bc7a8c378ba1991059ec30a637a9c00404 Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20107 Tested-by: Jenkins <[email protected]> Reviewed-by: Ian Maxon <[email protected]> (cherry picked from commit f038f0a591fd9d75bdfc6de2f66200f3a52af0f7) --- M asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java 1 file changed, 18 insertions(+), 13 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/17/20417/1 diff --git a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java index c89097b..c897cb7 100644 --- a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java +++ b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java @@ -429,16 +429,16 @@ handleLibraryDropStatement(metadataProvider, stmt, hcc, requestParameters); break; case CREATE_SYNONYM: - handleCreateSynonymStatement(metadataProvider, stmt); + handleCreateSynonymStatement(metadataProvider, stmt, requestParameters); break; case SYNONYM_DROP: - handleDropSynonymStatement(metadataProvider, stmt); + handleDropSynonymStatement(metadataProvider, stmt, requestParameters); break; case CREATE_VIEW: handleCreateViewStatement(metadataProvider, stmt, stmtRewriter, requestParameters); break; case VIEW_DROP: - handleViewDropStatement(metadataProvider, stmt); + handleViewDropStatement(metadataProvider, stmt, requestParameters); break; case LOAD: if (stats.getProfileType() == Stats.ProfileType.FULL) { @@ -2804,7 +2804,8 @@ } } - public void handleViewDropStatement(MetadataProvider metadataProvider, Statement stmt) throws Exception { + public void handleViewDropStatement(MetadataProvider metadataProvider, Statement stmt, + IRequestParameters requestParameters) throws Exception { ViewDropStatement stmtDrop = (ViewDropStatement) stmt; SourceLocation sourceLoc = stmtDrop.getSourceLocation(); String viewName = stmtDrop.getViewName().getValue(); @@ -2815,7 +2816,7 @@ } lockUtil.dropDatasetBegin(lockManager, metadataProvider.getLocks(), dataverseName, viewName); try { - doDropView(metadataProvider, stmtDrop, dataverseName, viewName); + doDropView(metadataProvider, stmtDrop, dataverseName, viewName, requestParameters); } finally { metadataProvider.getLocks().unlock(); ExternalDatasetsRegistry.INSTANCE.releaseAcquiredLocks(metadataProvider); @@ -2823,7 +2824,7 @@ } protected boolean doDropView(MetadataProvider metadataProvider, ViewDropStatement stmtViewDrop, - DataverseName dataverseName, String viewName) throws Exception { + DataverseName dataverseName, String viewName, IRequestParameters requestParameters) throws Exception { SourceLocation sourceLoc = stmtViewDrop.getSourceLocation(); MetadataTransactionContext mdTxnCtx = MetadataManager.INSTANCE.beginTransaction(); metadataProvider.setMetadataTxnContext(mdTxnCtx); @@ -3555,7 +3556,8 @@ } } - protected void handleCreateSynonymStatement(MetadataProvider metadataProvider, Statement stmt) throws Exception { + protected void handleCreateSynonymStatement(MetadataProvider metadataProvider, Statement stmt, + IRequestParameters requestParameters) throws Exception { CreateSynonymStatement css = (CreateSynonymStatement) stmt; metadataProvider.validateDatabaseObjectName(css.getDataverseName(), css.getSynonymName(), css.getSourceLocation()); @@ -3569,15 +3571,16 @@ } lockUtil.createSynonymBegin(lockManager, metadataProvider.getLocks(), dataverseName, synonymName); try { - doCreateSynonym(metadataProvider, css, dataverseName, synonymName, objectDataverseName, objectName); + doCreateSynonym(metadataProvider, css, dataverseName, synonymName, objectDataverseName, objectName, + requestParameters, true); } finally { metadataProvider.getLocks().unlock(); } } protected CreateResult doCreateSynonym(MetadataProvider metadataProvider, CreateSynonymStatement css, - DataverseName dataverseName, String synonymName, DataverseName objectDataverseName, String objectName) - throws Exception { + DataverseName dataverseName, String synonymName, DataverseName objectDataverseName, String objectName, + IRequestParameters requestParameters, boolean viaCreateSynonymStatement) throws Exception { MetadataTransactionContext mdTxnCtx = MetadataManager.INSTANCE.beginTransaction(); metadataProvider.setMetadataTxnContext(mdTxnCtx); try { @@ -3608,7 +3611,8 @@ } } - protected void handleDropSynonymStatement(MetadataProvider metadataProvider, Statement stmt) throws Exception { + protected void handleDropSynonymStatement(MetadataProvider metadataProvider, Statement stmt, + IRequestParameters requestParameters) throws Exception { SynonymDropStatement stmtSynDrop = (SynonymDropStatement) stmt; String synonymName = stmtSynDrop.getSynonymName(); metadataProvider.validateDatabaseObjectName(stmtSynDrop.getDataverseName(), synonymName, @@ -3619,14 +3623,15 @@ } lockUtil.dropSynonymBegin(lockManager, metadataProvider.getLocks(), dataverseName, synonymName); try { - doDropSynonym(metadataProvider, stmtSynDrop, dataverseName, synonymName); + doDropSynonym(metadataProvider, stmtSynDrop, dataverseName, synonymName, requestParameters, true); } finally { metadataProvider.getLocks().unlock(); } } protected boolean doDropSynonym(MetadataProvider metadataProvider, SynonymDropStatement stmtSynDrop, - DataverseName dataverseName, String synonymName) throws Exception { + DataverseName dataverseName, String synonymName, IRequestParameters requestParameters, + boolean viaDropSynonymStatement) throws Exception { MetadataTransactionContext mdTxnCtx = MetadataManager.INSTANCE.beginTransaction(); metadataProvider.setMetadataTxnContext(mdTxnCtx); try { -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20417?usp=email To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: asterixdb Gerrit-Branch: stabilization-0cde515801 Gerrit-Change-Id: I8134a6bc7a8c378ba1991059ec30a637a9c00404 Gerrit-Change-Number: 20417 Gerrit-PatchSet: 1 Gerrit-Owner: Ali Alsuliman <[email protected]>
