>From Michael Blow <[email protected]>: Attention is currently required from: Hussain Towaileb.
Michael Blow has posted comments on this change by Hussain Towaileb. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20485?usp=email ) Change subject: [ASTERIXDB-3657][FAIL]: handle non-serialize exceptions ...................................................................... Patch Set 5: (3 comments) Commit Message: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20485/comment/5a599571_8b6c8422?usp=email : PS5, Line 7: [ASTERIXDB-3657][FAIL]: handle non-serialize exceptions serializable* File hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/comm/ReplacementsAwareJavaSerializationProvider.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20485/comment/e86d2559_3852981a?usp=email : PS5, Line 62: return e.getValue().apply(object); I would add object.getClass() to the map and point it to e.getValue(), to avoid repeated instances checks. https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20485/comment/8baa9c7c_1c0b23ff?usp=email : PS5, Line 65: return super.replaceObject(object); I would add object.getClass() to the map and point it to super::replaceObject, to avoid repeated instances checks. -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20485?usp=email To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: asterixdb Gerrit-Branch: phoenix Gerrit-Change-Id: I55e69623068a6c1759803cc699417021910237fd Gerrit-Change-Number: 20485 Gerrit-PatchSet: 5 Gerrit-Owner: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Attention: Hussain Towaileb <[email protected]> Gerrit-Comment-Date: Wed, 15 Oct 2025 01:55:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
