>From Ian Maxon <[email protected]>: Attention is currently required from: Peeyush Gupta.
Ian Maxon has posted comments on this change by Peeyush Gupta. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20378?usp=email ) Change subject: [ASTERIXDB-3649][*DB] Improve async request API ...................................................................... Patch Set 9: (3 comments) File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/pushdown/PushdownContext.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20378/comment/bacf6bfa_1fcdd2ee?usp=email : PS9, Line 153: nit: revert? File asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/AbstractQueryApiServlet.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20378/comment/d6d87ff4_2a903bbb?usp=email : PS9, Line 156: if (error instanceof ErrorCode) { why not keep it an IError and predicate this on the value of IError.component() instead of using instanceof? File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20378/comment/dccedf9f_892ad5f3?usp=email : PS9, Line 4546: org.apache.asterix.translator.ResultMetadata resultMetadata) throws AlgebricksException, ACIDException { whys this a fully-qualified import? -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20378?usp=email To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: asterixdb Gerrit-Branch: phoenix Gerrit-Change-Id: I25c0651531a8a48271c901a7368d8668874a9d18 Gerrit-Change-Number: 20378 Gerrit-PatchSet: 9 Gerrit-Owner: Peeyush Gupta <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-CC: Ian Maxon <[email protected]> Gerrit-CC: Murtadha Hubail <[email protected]> Gerrit-Attention: Peeyush Gupta <[email protected]> Gerrit-Comment-Date: Fri, 10 Oct 2025 00:19:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
