>From Michael Blow <[email protected]>: Attention is currently required from: Hussain Towaileb.
Michael Blow has posted comments on this change by Hussain Towaileb. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20463?usp=email ) Change subject: [NO ISSUE]: Refactor AWS common properties ...................................................................... Patch Set 3: Code-Review+2 (1 comment) File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/aws/s3/S3Utils.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20463/comment/6152430f_003ce322?usp=email : PS3, Line 596: Boolean.parseBoolean(pathStyleAddressing) Boolean.parseBoolean() seems a bit extra since we only support true/false, but it doesn't matter either way. ```suggestion return "true".equalsIgnoreCase(pathStyleAddressing); ``` -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20463?usp=email To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: asterixdb Gerrit-Branch: phoenix Gerrit-Change-Id: I4d2a50d361ad949d4d3aeee3208bbd8dbb3e83a2 Gerrit-Change-Number: 20463 Gerrit-PatchSet: 3 Gerrit-Owner: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Attention: Hussain Towaileb <[email protected]> Gerrit-Comment-Date: Mon, 06 Oct 2025 13:56:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
