>From Michael Blow <[email protected]>: Attention is currently required from: Ritik Raj.
Michael Blow has posted comments on this change by Ritik Raj. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20549?usp=email ) Change subject: [NO ISSUE][CLOUD] Introduced config for S3 sync client ...................................................................... Patch Set 3: (2 comments) File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/CloudProperties.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20549/comment/1c137d44_b44c71ab?usp=email : PS3, Line 215: : @Override : public String usageDefaultOverride(IApplicationConfig accessor, Function<IOption, String> optionPrinter) { : if (this == CLOUD_STORAGE_S3_ENABLE_CRT_CLIENT) { : return "true when no custom endpoint is set, otherwise false"; : } : return IOption.super.usageDefaultOverride(accessor, optionPrinter); : } : } I don't think we should remove this, just update it to reflect the new setting and it semantics. https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20549/comment/4a79081a_d7aad8d1?usp=email : PS3, Line 80: CLOUD_STORAGE_S3_PARALLEL_DOWNLOADER_CLIENT_TYPE(STRING, (Function<IApplicationConfig, String>) app -> { : String endpoint = app.getString(CLOUD_STORAGE_ENDPOINT); : return (endpoint == null || endpoint.isEmpty()) ? "crt" : "async"; : }); We really should take the time to add proper validation for enum types here, but at the very least we need to add another one-off validation like we have for `StorageProperties.Option.STORAGE_COMPRESSION_BLOCK` in `ConfigValidator.validate(IOption, Object)`, to avoid bricking the cluster. If we took the time to add enum validation to IOptionTypes, we could avoid these one-offs. -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20549?usp=email To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: asterixdb Gerrit-Branch: phoenix Gerrit-Change-Id: Id16c530916e7e223201e2395d7aa38a4640367b6 Gerrit-Change-Number: 20549 Gerrit-PatchSet: 3 Gerrit-Owner: Ritik Raj <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-CC: Michael Blow <[email protected]> Gerrit-Attention: Ritik Raj <[email protected]> Gerrit-Comment-Date: Wed, 05 Nov 2025 12:27:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
