abdullah alamoudi has posted comments on this change. Change subject: Config Cleanup, Update Docs ......................................................................
Patch Set 8: (5 comments) https://asterix-gerrit.ics.uci.edu/#/c/1555/8/asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1_full/cluster_state_1_full.1.adm File asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1_full/cluster_state_1_full.1.adm: PS8, Line 13: "feed.memory.global.budget" : 67108864, rename this to active https://asterix-gerrit.ics.uci.edu/#/c/1555/8/asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1_less/cluster_state_1_less.1.adm File asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1_less/cluster_state_1_less.1.adm: PS8, Line 13: feed.memory.global.budget" : 67108864 active https://asterix-gerrit.ics.uci.edu/#/c/1555/8/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/ExternalProperties.java File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/ExternalProperties.java: PS8, Line 33: FEED_PORT(INTEGER, 19003, "The listen port of the feed server"), Rename to active? https://asterix-gerrit.ics.uci.edu/#/c/1555/8/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/FeedProperties.java File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/FeedProperties.java: PS8, Line 29: FeedProperties Can we rename this to active properties since this memory is shared across different active jobs (Feeds, BAD, etc,) PS8, Line 32: FEED_MEMORY_GLOBAL_BUDGET This one too -- To view, visit https://asterix-gerrit.ics.uci.edu/1555 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9edc9ced4c2b99db239a2075903f9d8b256c26e4 Gerrit-PatchSet: 8 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow <mb...@apache.org> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Till Westmann <ti...@apache.org> Gerrit-Reviewer: abdullah alamoudi <bamou...@gmail.com> Gerrit-HasComments: Yes
