>From Hussain Towaileb <[email protected]>: Attention is currently required from: Michael Blow.
Hussain Towaileb has posted comments on this change by Hussain Towaileb. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20567?usp=email ) Change subject: [NO ISSUE][EXT]: fix HDFS failing tests ...................................................................... Patch Set 2: Code-Review+1 (1 comment) File asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp_hdfs.xml: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20567/comment/046470d0_7036fd54?usp=email : PS1, Line 209: <placeholder name="additionalProperties" value="" /> > what are `additionalProperties` vs `additional_Properties`, and why do we > need both? AsterixDB supports this format in the WITH clause: WITH ( ("name"="john") ) While newer statements (like COPY TO) support the following: WITH { "name": "john" } it started as simply "additionalProperties" for the 2nd one, but when it was needed for old format, it was added as additional_Properties instead of a proper name. I haven't had the chance to surgically update all statements to have a better name for those 2 properties. -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20567?usp=email To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: asterixdb Gerrit-Branch: phoenix Gerrit-Change-Id: I2020976a0b9cb4b52b020e42f5954332ec52e2b4 Gerrit-Change-Number: 20567 Gerrit-PatchSet: 2 Gerrit-Owner: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Attention: Michael Blow <[email protected]> Gerrit-Comment-Date: Thu, 13 Nov 2025 10:04:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Michael Blow <[email protected]>
