>From Hussain Towaileb <[email protected]>: Attention is currently required from: Ali Alsuliman, Murtadha Hubail, Peeyush Gupta.
Hussain Towaileb has posted comments on this change by Peeyush Gupta. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20573?usp=email ) Change subject: [NO ISSUE][ET] Support Delta lake tables on Azure ...................................................................... Patch Set 3: (2 comments) File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/azure/delta/AzureDeltaReaderFactory.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20573/comment/5f275dee_c7ead507?usp=email : PS3, Line 46: BlobServiceClient Should you be building BlobServiceClient or DatalakeServiceClient? File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/azure/AzureUtils.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20573/comment/42edc471_94e4d151?usp=email : PS3, Line 124: getPath Is this method specifically needed for delta-tables? Doesn't seem to be used by blob/datalake. If so, can we move it to AzureDeltaReaderFactory? Or give it a name indicating it is delta-table-specific? -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20573?usp=email To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: asterixdb Gerrit-Branch: phoenix Gerrit-Change-Id: I528849556dc70d11cc5eb4ab55a7f7382c84061f Gerrit-Change-Number: 20573 Gerrit-PatchSet: 3 Gerrit-Owner: Peeyush Gupta <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Attention: Murtadha Hubail <[email protected]> Gerrit-Attention: Peeyush Gupta <[email protected]> Gerrit-Attention: Ali Alsuliman <[email protected]> Gerrit-Comment-Date: Fri, 14 Nov 2025 22:39:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
