>From Ian Maxon <[email protected]>: Attention is currently required from: Ali Alsuliman, Calvin Thomas Dani.
Ian Maxon has posted comments on this change by Calvin Thomas Dani. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20126?usp=email ) Change subject: [NO ISSUE] Vector Distance KNN Function ...................................................................... Patch Set 17: (2 comments) File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/utils/VectorDistanceArrCalculation.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20126/comment/7e20c5bd_113a8c6a?usp=email : PS17, Line 22: VectorDistanceArrCalculation all of these functions assume implicitly that a.length = b.length for the return value to be valid. we either should be very careful about calling these or make them check the lengths https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20126/comment/1bf040a2_8bf8206d?usp=email : PS17, Line 36: euclidean_squared camel case -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20126?usp=email To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I45176e7da13ed222f48bb36bd1f0ab4074a0bcb9 Gerrit-Change-Number: 20126 Gerrit-PatchSet: 17 Gerrit-Owner: Calvin Thomas Dani <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Attention: Calvin Thomas Dani <[email protected]> Gerrit-Attention: Ali Alsuliman <[email protected]> Gerrit-Comment-Date: Tue, 02 Dec 2025 01:10:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
