>From Hussain Towaileb <[email protected]>:

Attention is currently required from: Peeyush Gupta.

Hussain Towaileb has posted comments on this change by Hussain Towaileb. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20478?usp=email )

Change subject: [ASTERIXDB-3634][EXT]: Add support to Iceberg pt.2
......................................................................


Patch Set 5:

(2 comments)

File 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/awsclient/MyCustomAwsClientFactory.java:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20478/comment/35992731_dae90643?usp=email
 :
PS5, Line 47: proxyGlueClient
Ignore this for now, this is to find a way to close the inner most clients (STS 
client when assuming role) rather than just closing the Glue/S3 clients


File 
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/utils/IndexUtil.java:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20478/comment/d574c406_fb87d8bc?usp=email
 :
PS5, Line 389: NoOpIcebergTableFilterEvaluatorFactory.INSTANCE
I think this is where the filter work would begin for pruning and filtering



--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20478?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: I531c613fe061367b2cb5c187bc985b39d6de17d1
Gerrit-Change-Number: 20478
Gerrit-PatchSet: 5
Gerrit-Owner: Hussain Towaileb <[email protected]>
Gerrit-Reviewer: Hussain Towaileb <[email protected]>
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Reviewer: Peeyush Gupta <[email protected]>
Gerrit-Attention: Peeyush Gupta <[email protected]>
Gerrit-Comment-Date: Fri, 05 Dec 2025 18:44:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No

Reply via email to