>From Ali Alsuliman <[email protected]>: Attention is currently required from: Janhavi Tripurwar, Murtadha Hubail, Peeyush Gupta.
Ali Alsuliman has posted comments on this change by Janhavi Tripurwar. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20441?usp=email ) Change subject: [ASTERIXDB-3665]: Compute RangeMap at Compile time ...................................................................... Patch Set 30: (5 comments) File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/compiler/provider/DefaultRuleSetFactory.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20441/comment/205336a1_ba8990ee?usp=email : PS30, Line 54: } else if (ruleSetKind == RuleSetKind.RANGE_SAMPLING) { We should use RuleSetKind.SAMPLING File asterixdb/asterix-app/src/main/java/org/apache/asterix/api/java/AsterixJavaClient.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20441/comment/2d5371ba_ee3529cf?usp=email : PS30, Line 130: Set<String> alreadyInserted = new HashSet<>(); It's better to add ANALYZE only for the optimizer tests instead of for all calls of "compile()". Add a flag to distinguish. File asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/MetadataProvider.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20441/comment/7d8974c2_fd6b7b3e?usp=email : PS30, Line 236: maxResultReads = DEFAULT_MAX_RESULT_READS; What is this for? File hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/AbstractStableSortPOperator.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20441/comment/6cf6db30_1d4c65fe?usp=email : PS30, Line 90: && targetNodeDomain.cardinality() != null && targetNodeDomain.cardinality() > 1; Why did we remove ctx.getPhysicalOptimizationConfig().getSortParallel()? File hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/plan/PlanStructureVerifier.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20441/comment/f48ec99e_7fccd59a?usp=email : PS30, Line 218: // private void checkOperatorSchema(ILogicalOperator op) throws AlgebricksException { Remove -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20441?usp=email To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I51f99463d24596e74b5d435f718236de9016f2e8 Gerrit-Change-Number: 20441 Gerrit-PatchSet: 30 Gerrit-Owner: Janhavi Tripurwar <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Janhavi Tripurwar <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Peeyush Gupta <[email protected]> Gerrit-CC: Murtadha Hubail <[email protected]> Gerrit-Attention: Murtadha Hubail <[email protected]> Gerrit-Attention: Peeyush Gupta <[email protected]> Gerrit-Attention: Janhavi Tripurwar <[email protected]> Gerrit-Comment-Date: Wed, 10 Dec 2025 01:20:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
