>From Ali Alsuliman <[email protected]>: Attention is currently required from: Shahrzad Shirazi.
Ali Alsuliman has posted comments on this change by Shahrzad Shirazi. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20644?usp=email ) Change subject: [ASTERIXDB-3516][COMP] Improving the visitors for UPDATE statement ...................................................................... Patch Set 11: (1 comment) File asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/rewrites/visitor/SqlppChangeExprToSelectExprVisitor.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20644/comment/9f87439b_d33babe4?usp=email : PS6, Line 435: return expr.accept(new AbstractSqlppSimpleExpressionVisitor() { > I added this for detecting and changing statements like SET u.totaltax= u. […] Then create a variable above in the class and assign the object to it: private final AbstractSqlppSimpleExpressionVisitor substitueVisitor = new AbstractSqlppSimpleExpressionVisitor () { String originalVarName = null; VariableExpr newVar = null; @Override public Expression visit(VariableExpr varExpr, ILangExpression arg) throws CompilationException { return substituteVariableInExpression(varExpr, originalVarName, newVar); .... } and here do: substitueVisitor.originalVarName = originalVarName; substitueVisitor. newVar = newVar; return expr.accept(substitueVisitor, null); // shouldn't we pass something instead of null? -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20644?usp=email To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I87c5622716b261ed6ae6001e0cd84568e6690eae Gerrit-Change-Number: 20644 Gerrit-PatchSet: 11 Gerrit-Owner: Shahrzad Shirazi <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Attention: Shahrzad Shirazi <[email protected]> Gerrit-Comment-Date: Wed, 17 Dec 2025 04:48:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Shahrzad Shirazi <[email protected]> Comment-In-Reply-To: Ali Alsuliman <[email protected]>
