>From Ali Alsuliman <[email protected]>: Attention is currently required from: Ali Alsuliman, Ian Maxon.
Ali Alsuliman has posted comments on this change by Ian Maxon. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20270?usp=email ) Change subject: [ASTERIXDB-3631][RT] Profile nested groupby clauses ...................................................................... Patch Set 8: (2 comments) File hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/job/profiling/StatsCollector.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20270/comment/2c7c739a_704bdfe7?usp=email : PS8, Line 38: private final Map<String, IOperatorStats> operatorStatsMap = new ConcurrentHashMap<>(); > i don't believe so. […] "this structure is guarded by the locks around the task, which establish the correct sequence of events chronologically. however, that doesn't guarantee visibility of updates between threads, so even though the operators had long ago added the stats to the map, the thread managing the tasks can get a stale read." I am not sure I am following. Isn't the purpose of synchronized blocks is to make sure readers can see updates by writers where the synchronized blocks make the updates visible to other threads instead of being cached or something? File hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/preclustered/PreclusteredGroupWriter.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20270/comment/d45e3e3a_b077144c?usp=email : PS8, Line 93: aggregatorFactory.setOperatorStats(stats); > i tried this actually, i like it, but it doesn't pencil out. i see now why i > had to do it this way. […] My point was we normally don't modify the state of factories and think of them like immutable things when we are at the NC level. -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20270?usp=email To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I516dc90b8da3a7086dc80b67946ac14f6ade0973 Gerrit-Change-Number: 20270 Gerrit-PatchSet: 8 Gerrit-Owner: Ian Maxon <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Attention: Ian Maxon <[email protected]> Gerrit-Attention: Ali Alsuliman <[email protected]> Gerrit-Comment-Date: Wed, 17 Dec 2025 18:57:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Ian Maxon <[email protected]> Comment-In-Reply-To: Ali Alsuliman <[email protected]>
