>From Shahrzad Shirazi <[email protected]>: Attention is currently required from: Ali Alsuliman.
Shahrzad Shirazi has posted comments on this change by Shahrzad Shirazi. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20644?usp=email ) Change subject: [ASTERIXDB-3516][COMP] Improving the visitors for UPDATE statement ...................................................................... Patch Set 17: (10 comments) File asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/expression/ChangeExpression.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20644/comment/b246223e_fd279125?usp=email : PS10, Line 59: private SetExpressionTree exprTree; > IntelliJ is showing that "exprTree" could be final. Take a look at the > warnings and address them. Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20644/comment/bb05143d_cc2eb818?usp=email : PS10, Line 62: private Expression deleteUpateInsertTargetExpr; > Fix typo: deleteUpdateInsertTargetExpr, or better just changeTargetExpr Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20644/comment/5e7e74f1_bb1ef564?usp=email : PS10, Line 139: public Expression getDeleteUpateInsertTargetExpr() { > getChangeTargetExpr() Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20644/comment/2478b25d_93221bc0?usp=email : PS10, Line 167: public void setDeleteUpateInsertTargetExpr(Expression deleteUpateInsertTargetExpr) { > setChangeTargetExpr(Expression changeTargetExpr) Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20644/comment/17ad0b29_1b884813?usp=email : PS10, Line 207: public boolean hasPathExpr() { > hasChangeTargetExpr() Done File asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/parser/SetExpressionTree.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20644/comment/717ab182_ca136d90?usp=email : PS10, Line 74: public class SetExpressionTree { > IntelliJ is showing a couple of warnings. Take a look and address them. They > are easy ones like: […] Done File asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/rewrites/SqlppQueryRewriter.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20644/comment/6e39c438_82342f2f?usp=email : PS10, Line 179: rewriteUpdateModificationExpressions(); > With all the renaming we did, check if a better name for this could be: […] Done File asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/rewrites/visitor/SqlppChangeExprToSelectExprVisitor.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20644/comment/d1c7a74e_b1da1def?usp=email : PS6, Line 435: return expr.accept(new AbstractSqlppSimpleExpressionVisitor() { > Then create a variable above in the class and assign the object to it: […] Done File asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/visitor/CheckSql92AggregateVisitor.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20644/comment/3372aae1_02918c84?usp=email : PS10, Line 321: || (changeExpr.getValueExprs() != null && visitExprList(changeExpr.getValueExprs(), arg)) > We are missing the pathExprs. Done File asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/visitor/SqlppFormatPrintVisitor.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20644/comment/103163b3_f490d9fc?usp=email : PS10, Line 361: if (changeExpr.getPathExprs().size() != 0) { > Try to be consistent. In 'SqlppAstPrintVisitor', you are using: […] Done -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20644?usp=email To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I87c5622716b261ed6ae6001e0cd84568e6690eae Gerrit-Change-Number: 20644 Gerrit-PatchSet: 17 Gerrit-Owner: Shahrzad Shirazi <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Attention: Ali Alsuliman <[email protected]> Gerrit-Comment-Date: Fri, 19 Dec 2025 19:48:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Shahrzad Shirazi <[email protected]> Comment-In-Reply-To: Ali Alsuliman <[email protected]>
