>From Hussain Towaileb <[email protected]>: Attention is currently required from: Preetham Poluparthi.
Hussain Towaileb has posted comments on this change by Preetham Poluparthi. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20788?usp=email ) Change subject: [ASTERIXDB-3392][EXT] Fix false warnings while querying parquet ...................................................................... Patch Set 1: Code-Review+2 (2 comments) File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/HDFSDataSourceFactory.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20788/comment/d2b63501_1f713c06?usp=email : PS1, Line 326: /* : * JobConf is used to pass warnings from the ParquetReadSupport to ParquetReader. As multiple : * partitions can issue different warnings, we might have a race condition on JobConf. Thus, we : * should create a copy when warnings are enabled. : */ We will always create a copy now even if warnings are disabled? Also, confFactory.getConf() returns a copy? File asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/provider/ExternalWriterProvider.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20788/comment/39fff676_4157170f?usp=email : PS1, Line 105: ExternalDataConstants.FORMAT_PARQUET can this be + format? -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20788?usp=email To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: Id2dc25a30ea1bf7012f945803befc2751f33b86a Gerrit-Change-Number: 20788 Gerrit-PatchSet: 1 Gerrit-Owner: Preetham Poluparthi <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Preetham Poluparthi <[email protected]> Gerrit-Attention: Preetham Poluparthi <[email protected]> Gerrit-Comment-Date: Mon, 12 Jan 2026 18:32:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
