>From Ian Maxon <[email protected]>: Attention is currently required from: Peeyush Gupta.
Ian Maxon has posted comments on this change by Peeyush Gupta. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20768?usp=email ) Change subject: [ASTERIXDB-3686][API] Incorrect response for failed async request ...................................................................... Patch Set 3: (1 comment) File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20768/comment/2b36e542_44d3e421?usp=email : PS3, Line 5726: private void handleAsyncJobException(Throwable e, JobId jobId, ResultDelivery resultDelivery) { : if (Objects.equals(JobId.INVALID, jobId)) { : // compilation failed : responsePrinter.addResultPrinter(new StatusPrinter(AbstractQueryApiServlet.ResultStatus.FAILED)); : responsePrinter.addResultPrinter(new ErrorsPrinter(Collections.singletonList(ExecutionError.of(e)))); : try { : responsePrinter.printResults(); : } catch (HyracksDataException ex) { : LOGGER.error("failed to print result", ex); : } : } else { : GlobalConfig.ASTERIX_LOGGER.log(Level.ERROR, : resultDelivery.name() + " job with id " + jobId + " " + "failed", e); : } : } so basically this was just an orphan piece of printing code, and bubbling up to the one in e.g. handleExecuteStatementException() is the correct way to do it? -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20768?usp=email To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I9ca684c1a90403ba2813cc858be76be69b8a4a6d Gerrit-Change-Number: 20768 Gerrit-PatchSet: 3 Gerrit-Owner: Peeyush Gupta <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Attention: Peeyush Gupta <[email protected]> Gerrit-Comment-Date: Tue, 13 Jan 2026 00:27:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
