>From Peeyush Gupta <[email protected]>: Attention is currently required from: Ian Maxon.
Peeyush Gupta has posted comments on this change by Peeyush Gupta. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20771?usp=email ) Change subject: [ASTERIXDB-3687][API] Incorrect metrics and missing fields in status API ...................................................................... Patch Set 7: (3 comments) File asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/NCQueryStatusApiServlet.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20771/comment/3c4ae399_c59c964f?usp=email : PS5, Line 83: default -> null; > might kind of be paranoia but to me it's better to return a dummy/invalid > response metric here inste […] Done File asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryStatusApiServlet.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20771/comment/27ed49af_a4dd783c?usp=email : PS5, Line 207: long currentTime = System.currentTimeMillis(); : long requestCreateTime = ((ClientRequest) clientRequest.get()).getCreationSystemTime(); : long elapsedTime = TimeUnit.MILLISECONDS.toNanos(currentTime - requestCreateTime); : long compileTime = TimeUnit.MILLISECONDS.toNanos(run.getCreateTime() - requestCreateTime); : ResponseMetrics metrics = switch (status) { : case QUEUED -> ResponseMetrics.of( : elapsedTime, 0, 0, : 0, 0, 0, 0, compileTime, : run.getQueueWaitTimeInMillis(), 0, 0, 0, 0, 0); : case RUNNING -> ResponseMetrics.of( : elapsedTime, : TimeUnit.MILLISECONDS.toNanos(currentTime - run.getStartTime()), 0, 0, 0, 0, 0, : compileTime, : run.getQueueWaitTimeInMillis(), 0, 0, 0, 0, 0); : default -> null; : }; : printer.addFooterPrinter(new MetricsPrinter(metrics, HttpUtil.getPreferredCharset(request), : Set.of(MetricsPrinter.Metrics.ELAPSED_TIME, MetricsPrinter.Metrics.EXECUTION_TIME, : MetricsPrinter.Metrics.QUEUE_WAIT_TIME, MetricsPrinter.Metrics.COMPILE_TIME))); : printer.addFooterPrinter(new CreatedAtPrinter(requestCreateTime)); > this fragment is almost the same as the one in NCQueryServiceServlet isn't > it? is there no easy way […] Done File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20771/comment/2dbc322f_03cc8c3f?usp=email : PS5, Line 5577: resultMetadata.setCreateTime(System.currentTimeMillis()); > this changes the meaning of the field to now be slightly after compile time > rather than when the job […] The create time metric is for request creation time and not job creation time. -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20771?usp=email To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: Id5fd38b4273d1a3c98936cea63b8c879e474d619 Gerrit-Change-Number: 20771 Gerrit-PatchSet: 7 Gerrit-Owner: Peeyush Gupta <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Attention: Ian Maxon <[email protected]> Gerrit-Comment-Date: Tue, 13 Jan 2026 04:15:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Ian Maxon <[email protected]>
