>From Wail Alkowaileet <[email protected]>: Attention is currently required from: Ritik Raj.
Wail Alkowaileet has posted comments on this change by Ritik Raj. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20792?usp=email ) Change subject: [ASTERIXDB-3684][STO] Added testcases related to temporal types ...................................................................... Patch Set 1: (2 comments) File asterixdb/asterix-column/src/test/java/org/apache/asterix/column/encdec/ParquetDeltaBinaryPackingValuesWriterForIntegerTest.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20792/comment/64f498fd_2b6b98b5?usp=email : PS1, Line 41: ParquetDeltaBinaryPackingValuesWriterForIntegerTest > LLM generated, seems correct to me I remember there's an email about using LLM generated code - that we should use some tags or comments? or something in the commit message? or all of the above 😊 https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20792/comment/b76e7562_e872753e?usp=email : PS1, Line 83: assertRoundTrip Minor: Although the tests are great, decodePage() doesn't check if the number of values is correct (the most ugly issue we had was "no more values"). Every test that would fail will be because the byte array is not the same. It won't tell you that because you have more/less values than expected. -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20792?usp=email To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I35231099dc48077f61a5cff32c58232461edf82e Gerrit-Change-Number: 20792 Gerrit-PatchSet: 1 Gerrit-Owner: Ritik Raj <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Wail Alkowaileet <[email protected]> Gerrit-Attention: Ritik Raj <[email protected]> Gerrit-Comment-Date: Wed, 14 Jan 2026 06:17:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Ritik Raj <[email protected]>
