>From Shahrzad Shirazi <[email protected]>: Attention is currently required from: Peeyush Gupta.
Shahrzad Shirazi has posted comments on this change by Shahrzad Shirazi. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20774?usp=email ) Change subject: [ASTERIXDB-3688][COMP] Improving Index Selection for Index-Only Query Plans ...................................................................... Patch Set 8: (1 comment) File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AbstractIntroduceAccessMethodRule.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20774/comment/1ea3f7b5_b5d57535?usp=email : PS7, Line 307: else if (!appliedIndexTypes.contains(indexType)) { : appliedIndexTypes.add(indexType); : result.add(new IntroduceSelectAccessMethodRule.IndexAccessInfo(chosenAccessMethod, : chosenIndex)); : } > If a covering index is found and then we iterate over a non covering index > then the […] No, the logic had an issue, thanks for pointing it out. If we’ve found a covering index, we should only check for better covering indexes (those with fewer additional fields). I made some small changes to ensure that non-covering indexes are not added. Does it look better now? -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20774?usp=email To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I4f996ee7b6eb03067fb384161fb4eb60f94e8353 Gerrit-Change-Number: 20774 Gerrit-PatchSet: 8 Gerrit-Owner: Shahrzad Shirazi <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Peeyush Gupta <[email protected]> Gerrit-Reviewer: Preetham Poluparthi <[email protected]> Gerrit-Attention: Peeyush Gupta <[email protected]> Gerrit-Comment-Date: Thu, 15 Jan 2026 21:17:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Peeyush Gupta <[email protected]>
