Yingyi Bu has posted comments on this change. Change subject: Unify structure of Cluster Controller and Node Controller ......................................................................
Patch Set 10: Code-Review-1 (4 comments) https://asterix-gerrit.ics.uci.edu/#/c/1514/10/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/application/ICCApplication.java File hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/application/ICCApplication.java: PS10, Line 28: IHyracksClientConnection Why Hcc is part of an CC Application? It looks to be a client-side thing. We shouldn't bound hcc to a server application, the current compiler should be factored out of CC. https://asterix-gerrit.ics.uci.edu/#/c/1514/10/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/BaseCCApplication.java File hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/BaseCCApplication.java: PS10, Line 72: null Why context is an Object? Can we have some abstraction for it? PS10, Line 75: Override Why A ICCApplication needs hcc? It looks to me that hcc is a client-side thing. https://asterix-gerrit.ics.uci.edu/#/c/1514/10/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/BaseNCApplication.java File hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/BaseNCApplication.java: PS10, Line 71: getApplicationContext Why context is an Object? Can we have some abstraction for it? E.g., it provides an abstraction that is similar to a map? -- To view, visit https://asterix-gerrit.ics.uci.edu/1514 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ife3a002371a07ee9cdd32e1ffd50cc775bf1d453 Gerrit-PatchSet: 10 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <bamou...@gmail.com> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Michael Blow <mb...@apache.org> Gerrit-Reviewer: Yingyi Bu <buyin...@gmail.com> Gerrit-Reviewer: abdullah alamoudi <bamou...@gmail.com> Gerrit-HasComments: Yes
