>From Ali Alsuliman <[email protected]>: Attention is currently required from: Preetham Poluparthi.
Ali Alsuliman has posted comments on this change by Preetham Poluparthi. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20950?usp=email ) Change subject: [ASTERIXDB-3709][COMP] Support disjunctions in index lookups ...................................................................... Patch Set 5: (1 comment) File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AbstractIntroduceAccessMethodRule.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20950/comment/48a2e7cc_a9a2e9c8?usp=email : PS5, Line 755: analyzedAMs.clear(); : analyzedAMs.putAll(disjuncAnalyzedAMs); If not found, then some AccessMethodAnalysisContext references might have been modified mid-way. We can make it simpler. Since we know we are targeting `BTreeAccessMethod`, make `disjuncAnalyzedAMs` empty. After we are done, we just pick the `BTreeAccessMethod` by calling `disjuncAnalyzedAMs.get(BTreeAccessMethod.INSTANCE` and checking if it is null or not. If it is there, then just add all `IOptimizableFuncExpr` from BTreeAccessMethod in `disjuncAnalyzedAMs` to BTreeAccessMethod in `analyzedAMs`. If`analyzedAMs` does not have a BTreeAccessMethod, then we just put it `analyzedAMs.put()` -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20950?usp=email To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: asterixdb Gerrit-Branch: phoenix Gerrit-Change-Id: I5979630883e718ac0cbd3a380cb752658c47d4f5 Gerrit-Change-Number: 20950 Gerrit-PatchSet: 5 Gerrit-Owner: Preetham Poluparthi <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-CC: Michael Blow <[email protected]> Gerrit-Attention: Preetham Poluparthi <[email protected]> Gerrit-Comment-Date: Mon, 02 Mar 2026 04:21:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
