>From Michael Blow <[email protected]>: Attention is currently required from: Ali Alsuliman, Ritik Raj.
Michael Blow has posted comments on this change by Ritik Raj. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20967?usp=email ) Change subject: [NO ISSUE][HYR] Fix NPE in AbstractIoOperation and improve cloud interrupt handling ...................................................................... Patch Set 5: (2 comments) File hyracks-fullstack/hyracks/hyracks-cloud/src/main/java/org/apache/hyracks/cloud/util/CloudRetryableRequestUtil.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20967/comment/f5a3aa92_3089c09d?usp=email : PS5, Line 114: // won't clear the interrupted status, just check it : boolean currentCycleInterrupted = Thread.currentThread().isInterrupted(); : // First, clear the interrupted flag : interrupted |= Thread.interrupted(); : if (ExceptionUtils.causedByInterrupt(e) || currentCycleInterrupted) { : ```suggestion // clear & check any interrupted status boolean currentCycleInterrupted = Thread.currentThread().isInterrupted(); interrupted |= currentCycleInterrupted; if (ExceptionUtils.causedByInterrupt(e) || currentCycleInterrupted) { interrupted = true; ``` File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/AbstractIoOperation.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20967/comment/853b1ee5_abee0ac6?usp=email : PS5, Line 99: if (failure == null) { : failure = hde; : } else { : getFailure().addSuppressed(hde); : } we have a util method which does this, `failure = ExceptionUtils.suppress(failure, hde)` -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20967?usp=email To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: asterixdb Gerrit-Branch: lumina Gerrit-Change-Id: If36c1336f8e8377f2d410c8878d168f1209bcf87 Gerrit-Change-Number: 20967 Gerrit-PatchSet: 5 Gerrit-Owner: Ritik Raj <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Ritik Raj <[email protected]> Gerrit-CC: Anon. E. Moose #1000171 Gerrit-CC: Murtadha Hubail <[email protected]> Gerrit-Attention: Ali Alsuliman <[email protected]> Gerrit-Attention: Ritik Raj <[email protected]> Gerrit-Comment-Date: Wed, 11 Mar 2026 14:19:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
