>From Suryaa Charan Shivakumar <[email protected]>: Attention is currently required from: Ian Maxon.
Suryaa Charan Shivakumar has posted comments on this change by Suryaa Charan Shivakumar. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20968?usp=email ) Change subject: [ASTERIXDB-3542] Added Coordinate Reference System support at Metadata and ST Transform function ...................................................................... Patch Set 4: (2 comments) File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/handlers/CRSStatementHandler.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20968/comment/10039199_67c8f12d?usp=email : PS3, Line 181: Path dirPath = Paths.get(stmt.getDirectoryPath()); : if (!Files.exists(dirPath) || !Files.isDirectory(dirPath) || !Files.isReadable(dirPath)) { : throw new CompilationException(ErrorCode.INVALID_REQ_PARAM_VAL, stmt.getSourceLocation(), "path", : stmt.getDirectoryPath() + " (directory not found or not readable)"); : } : : File[] files = dirPath.toFile().listFiles(); : if (files == null) { : throw new CompilationException(ErrorCode.INVALID_REQ_PARAM_VAL, stmt.getSourceLocation(), "path", : stmt.getDirectoryPath() + " (unable to list directory)"); : } > as discussed i think loading the file off the CC is kind of too raw. […] Done, removed it from patchset 4 File asterixdb/asterix-lang-sqlpp/src/main/javacc/SQLPP.jj: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20968/comment/3d74c5c0_16212585?usp=email : PS3, Line 1305: CRSCreateStatement CreateCRSStatement(Token startStmtToken) throws ParseException: : { : int srid; : boolean ifNotExists = false; : String crsName = null; : String crsWkt = null; : } : { : // consume "COORDINATE" : <IDENTIFIER> { expectToken(COORDINATE); } : // consume "REFERENCE" : <IDENTIFIER> { expectToken(REFERENCE); } : // consume "SYSTEM" : <IDENTIFIER> { expectToken(SYSTEM); } : <INTEGER_LITERAL> : { : long sridLong; : try { : sridLong = Long.parseLong(token.image); : } catch (NumberFormatException e) { : throw new SqlppParseException(getSourceLocation(token), "Invalid SRID value: " + token.image); : } : if (sridLong < 1 || sridLong > Integer.MAX_VALUE) { : throw new SqlppParseException(getSourceLocation(token), : "SRID must be a positive integer (1 to " + Integer.MAX_VALUE + "), got: " + sridLong); : } : srid = (int) sridLong; : } : ifNotExists = IfNotExists() : // consume "NAME" : <IDENTIFIER> { expectToken(NAME); } : crsName = StringLiteral() : <AS> : crsWkt = StringLiteral() : { : CRSCreateStatement stmt = new CRSCreateStatement(srid, crsName, crsWkt, ifNotExists); : return addSourceLocation(stmt, startStmtToken); : } : } > if you don't forsee a reason to have a version of CREATE COORDINATE REFERENCE > SYSTEM that would acce […] There is a version of CREATE CRS -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20968?usp=email To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: Ia6e37080a581292744ddc9020b214926412c16ac Gerrit-Change-Number: 20968 Gerrit-PatchSet: 4 Gerrit-Owner: Suryaa Charan Shivakumar <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-CC: Ian Maxon <[email protected]> Gerrit-Attention: Ian Maxon <[email protected]> Gerrit-Comment-Date: Fri, 13 Mar 2026 05:34:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Ian Maxon <[email protected]>
