>From Shahrzad Shirazi <[email protected]>:

Shahrzad Shirazi has submitted this change. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21075?usp=email )

Change subject: [ASTERIXDB-3749][COMP] Fix default values of compiler properties
......................................................................

[ASTERIXDB-3749][COMP] Fix default values of compiler properties

- user model changes: no
- storage format changes: no
- interface changes: no

Ext-ref: MB-71173
Change-Id: I4b55280fc071bfde1b1962f9381e4d28b223188a
Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21075
Integration-Tests: Jenkins <[email protected]>
Reviewed-by: Ali Alsuliman <[email protected]>
Reviewed-by: Shahrzad Shirazi <[email protected]>
Tested-by: Jenkins <[email protected]>
---
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1/cluster_state_1.1.regexadm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1_full/cluster_state_1_full.1.regexadm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1_less/cluster_state_1_less.1.regexadm
M 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/config/AlgebricksConfig.java
4 files changed, 9 insertions(+), 9 deletions(-)

Approvals:
  Jenkins: Verified; Verified
  Ali Alsuliman: Looks good to me, approved
  Shahrzad Shirazi: Looks good to me, but someone else must approve

Objections:
  Anon. E. Moose #1000171: Violations found




diff --git 
a/asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1/cluster_state_1.1.regexadm
 
b/asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1/cluster_state_1.1.regexadm
index edd93ae..40acc6c 100644
--- 
a/asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1/cluster_state_1.1.regexadm
+++ 
b/asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1/cluster_state_1.1.regexadm
@@ -46,10 +46,10 @@
     "compiler.column.filter" : true,
     "compiler.copy.to.write.buffer.size" : 8388608,
     "compiler.deltalake.filesplits" : false,
-    "compiler.disjunction.as.join" : false,
+    "compiler.disjunction.as.join" : true,
     "compiler.disjunction.hash.threshold" : 40,
     "compiler\.external\.field\.pushdown" : true,
-    "compiler.extract.common.expression.limit" : 100,
+    "compiler.extract.common.expression.limit" : 10000,
     "compiler.forcejoinorder" : false,
     "compiler\.framesize" : 32768,
     "compiler\.groupmemory" : 163840,
@@ -62,7 +62,7 @@
     "compiler\.min\.memory\.allocation" : true,
     "compiler.min.sortmemory" : 524288,
     "compiler.min.windowmemory" : 524288,
-    "compiler\.optimize\.expression.max\.args" : 100,
+    "compiler\.optimize\.expression.max\.args" : 10000,
     "compiler.ordered.fields" : false,
     "compiler\.parallelism" : 0,
     "compiler.queryplanshape" : "zigzag",
diff --git 
a/asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1_full/cluster_state_1_full.1.regexadm
 
b/asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1_full/cluster_state_1_full.1.regexadm
index b616a93..82f65e2 100644
--- 
a/asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1_full/cluster_state_1_full.1.regexadm
+++ 
b/asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1_full/cluster_state_1_full.1.regexadm
@@ -49,7 +49,7 @@
     "compiler.disjunction.as.join" : true,
     "compiler.disjunction.hash.threshold" : 40,
     "compiler.external.field.pushdown" : true,
-    "compiler.extract.common.expression.limit" : 1000,
+    "compiler.extract.common.expression.limit" : 10000,
     "compiler.forcejoinorder" : false,
     "compiler\.framesize" : 32768,
     "compiler\.groupmemory" : 163840,
@@ -62,7 +62,7 @@
     "compiler\.min\.memory\.allocation" : true,
     "compiler.min.sortmemory" : 524288,
     "compiler.min.windowmemory" : 524288,
-    "compiler.optimize.expression.max.args" : 1000,
+    "compiler.optimize.expression.max.args" : 10000,
     "compiler.ordered.fields" : false,
     "compiler\.parallelism" : -1,
     "compiler.queryplanshape" : "zigzag",
diff --git 
a/asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1_less/cluster_state_1_less.1.regexadm
 
b/asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1_less/cluster_state_1_less.1.regexadm
index e51150e5f..cb57a47 100644
--- 
a/asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1_less/cluster_state_1_less.1.regexadm
+++ 
b/asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1_less/cluster_state_1_less.1.regexadm
@@ -49,7 +49,7 @@
     "compiler.disjunction.as.join" : true,
     "compiler.disjunction.hash.threshold" : 40,
     "compiler\.external\.field\.pushdown" : true,
-    "compiler.extract.common.expression.limit" : 1000,
+    "compiler.extract.common.expression.limit" : 10000,
     "compiler.forcejoinorder" : false,
     "compiler\.framesize" : 32768,
     "compiler\.groupmemory" : 163840,
@@ -62,7 +62,7 @@
     "compiler\.min\.memory\.allocation" : true,
     "compiler.min.sortmemory" : 524288,
     "compiler.min.windowmemory" : 524288,
-    "compiler.optimize.expression.max.args" : 1000,
+    "compiler.optimize.expression.max.args" : 10000,
     "compiler.ordered.fields" : false,
     "compiler\.parallelism" : 3,
     "compiler.queryplanshape" : "zigzag",
diff --git 
a/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/config/AlgebricksConfig.java
 
b/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/config/AlgebricksConfig.java
index b8a37b33..96e8a46 100644
--- 
a/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/config/AlgebricksConfig.java
+++ 
b/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/config/AlgebricksConfig.java
@@ -50,6 +50,6 @@
     public static final boolean ORDERED_FIELDS = true;
     public static final int MAX_VARIABLE_OCCURRENCES_INLINING_DEFAULT = 128;
     public static final int HASH_BASED_OR_THRESHOLD_DEFAULT = 40;
-    public static final int MAX_EXPRESSION_TREE_SIZE_DEFAULT = 1000;
-    public static final int COMMON_EXPRESSION_LIMIT_DEFAULT = 1000;
+    public static final int MAX_EXPRESSION_TREE_SIZE_DEFAULT = 10000;
+    public static final int COMMON_EXPRESSION_LIMIT_DEFAULT = 10000;
 }

--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21075?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings?usp=email

Gerrit-MessageType: merged
Gerrit-Project: asterixdb
Gerrit-Branch: phoenix
Gerrit-Change-Id: I4b55280fc071bfde1b1962f9381e4d28b223188a
Gerrit-Change-Number: 21075
Gerrit-PatchSet: 3
Gerrit-Owner: Shahrzad Shirazi <[email protected]>
Gerrit-Reviewer: Ali Alsuliman <[email protected]>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Reviewer: Michael Blow <[email protected]>
Gerrit-Reviewer: Shahrzad Shirazi <[email protected]>

Reply via email to