>From Calvin Thomas Dani <[email protected]>: Attention is currently required from: Ali Alsuliman, Ian Maxon.
Calvin Thomas Dani has posted comments on this change by Calvin Thomas Dani. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20126?usp=email ) Change subject: [ASTERIXDB-3676] Vector Distance Functions ...................................................................... Patch Set 21: (8 comments) Commit Message: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20126/comment/861aaa37_9451a817?usp=email : PS17, Line 7: NO ISSUE > add the issue here Acknowledged https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20126/comment/eaec66f4_756535aa?usp=email : PS17, Line 9: no > it does add functions, so yes Acknowledged https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20126/comment/81786f76_71275af3?usp=email : PS17, Line 14: vector_distance_constant() > i removed this because it was basically entirely duplicated. […] Acknowledged https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20126/comment/aa0734a3_22ade16d?usp=email : PS17, Line 17: KNN > this really isn't KNN, right? maybe we will use it as part of KNN but this > itself isn't Acknowledged File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/vector/VectorDistanceArrScalarEvaluator.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20126/comment/2deeae4d_e878fc39?usp=email : PS17, Line 189: if(!isConstant[0]) { : vectorPool.free(primitiveArray1); : } : if(!isConstant[1]) { : vectorPool.free(primitiveArray2); : } > probably change this so that the array is given as a parameter to > createPrimitiveList, and maybe cha […] Acknowledged File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/vector/VectorDistanceArrScalarEvaluator.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20126/comment/a10b428c_19e3cd0d?usp=email : PS19, Line 174: double[] primitiveArrayLeft = : isConstant[0] ? primitiveArrayConstant[0] : createArrayFromList(leftListAccessor, vectorArrays[0]); : double[] primitiveArrayRight = : isConstant[1] ? primitiveArrayConstant[1] : createArrayFromList(rightListAccessor, vectorArrays[1]); > We need to handle the less common case where each evaluated tuple has > different arguments length tha […] No, this distinction is about whether the query vector comes from a constant expression in the function call or from a field evaluator when reading each record. For a constant input, I compute the embedding array once. For dynamic inputs coming from the dataset, the embedding is evaluated per record during query execution. https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20126/comment/036b8db4_75460516?usp=email : PS19, Line 194: AMutableDouble aDouble = new AMutableDouble(-1); > Same idea. […] Acknowledged https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20126/comment/4901cf96_0d0e054f?usp=email : PS19, Line 203: IPointable tempVal = new VoidPointable(); : ArrayBackedValueStorage storage = new ArrayBackedValueStorage(); > Same idea. […] Acknowledged -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20126?usp=email To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I45176e7da13ed222f48bb36bd1f0ab4074a0bcb9 Gerrit-Change-Number: 20126 Gerrit-PatchSet: 21 Gerrit-Owner: Calvin Thomas Dani <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Attention: Ian Maxon <[email protected]> Gerrit-Attention: Ali Alsuliman <[email protected]> Gerrit-Comment-Date: Mon, 06 Apr 2026 19:55:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Ian Maxon <[email protected]> Comment-In-Reply-To: Ali Alsuliman <[email protected]>
