>From Shahrzad Shirazi <[email protected]>:

Attention is currently required from: Murtadha Hubail.

Shahrzad Shirazi has posted comments on this change by Shahrzad Shirazi. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20962?usp=email )

Change subject: [ASTERIXDB-3719][COMP] Using index when redundant range 
predicates are present
......................................................................


Patch Set 13:

(1 comment)

File 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/BTreeAccessMethod.java:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20962/comment/30f64719_398a701d?usp=email
 :
PS10, Line 514: // Multiple upper-bound predicates on the same key (e.g., a < 3 
AND a < 5).
              :                         // Pick the tighter (smaller) bound if 
both are constants.
              :                         int cmp = 
compareConstants(searchKeyExpr, highKeyExprs[keyPos]);
              :                         if (cmp != 0) {
              :                             if (cmp < 0) {
              :                                 highKeyLimits[keyPos] = limit;
              :                                 highKeyExprs[keyPos] = 
searchKeyExpr;
              :                                 highKeyInclusive[keyPos] = 
false;
              :                             }
              :                         } else {
              :                             couldntFigureOut = true;
              :                             doneWithExprs = true;
              :                         }
              :                     }
> This method is already too long. See if you can extract this new logic to its 
> own method. […]
Done



--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20962?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: Ifc39ad34b8bf551d21567963b8507c6961eae90d
Gerrit-Change-Number: 20962
Gerrit-PatchSet: 13
Gerrit-Owner: Shahrzad Shirazi <[email protected]>
Gerrit-Reviewer: Ali Alsuliman <[email protected]>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Reviewer: Preetham Poluparthi <[email protected]>
Gerrit-Reviewer: Shahrzad Shirazi <[email protected]>
Gerrit-CC: Murtadha Hubail <[email protected]>
Gerrit-Attention: Murtadha Hubail <[email protected]>
Gerrit-Comment-Date: Thu, 16 Apr 2026 18:01:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Murtadha Hubail <[email protected]>

Reply via email to