>From Ali Alsuliman <[email protected]>:

Ali Alsuliman has posted comments on this change by Ali Alsuliman. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21151?usp=email )

Change subject: [ASTERIXDB-3687][API] Ensure consistent time units used for 
request metrics
......................................................................


Patch Set 2:

(1 comment)

File 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryResultApiServlet.java:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21151/comment/7298146d_02a60aa7?usp=email
 :
PS2, Line 178:         return 
ResponseMetrics.of(TimeUnit.MILLISECONDS.toNanos(endTime - 
metadata.getCreateTimeMillis()),
This elapsedTime:
```TimeUnit.MILLISECONDS.toNanos(endTime - metadata.getCreateTimeMillis()```
feels like should be
```
long startTime = System.currentTimeMillis();
...
TimeUnit.MILLISECONDS.toNanos(endTime - startTime)```



--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21151?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: asterixdb
Gerrit-Branch: lumina
Gerrit-Change-Id: Ifa04a02b8d950ae6e283c940e679cb2e25acee48
Gerrit-Change-Number: 21151
Gerrit-PatchSet: 2
Gerrit-Owner: Ali Alsuliman <[email protected]>
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Comment-Date: Tue, 21 Apr 2026 13:38:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No

Reply via email to