>From Preetham Poluparthi <[email protected]>: Attention is currently required from: Ali Alsuliman.
Preetham Poluparthi has posted comments on this change by Preetham Poluparthi. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21139?usp=email ) Change subject: [ASTERIXDB-3755][EXT] Improve parquet row group filters while querying external collections ...................................................................... Patch Set 7: Code-Review+1 (5 comments) File asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/utils/filter/ParquetFilterBuilder.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21139/comment/251d318a_4b8428d0?usp=email : PS6, Line 82: if (arg1.getExpressionTag().equals(LogicalExpressionTag.CONSTANT)) { > `LogicalExpressionTag` is enum. You can use `==` instead of equals(). Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21139/comment/a39b35de_9c31c0c3?usp=email : PS6, Line 89: LOGGER.info("Unsupported expression for row-group filter: " + arg1 + ", " + arg2); > We are still missing redaction for: `arg1 + ", " + arg2`. There are others > below, too. Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21139/comment/f41fe714_6aed7d9c?usp=email : PS6, Line 94: LOGGER.info("Unsupported literal type for row-group filter: " + constExpr.getValue()); > Redact `constExpr. […] Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21139/comment/721d19ee_afd8c5ea?usp=email : PS6, Line 134: LOGGER.info("Unsupported literal type for row-group filter: " + constantValue.getObject().getType()); > Redact `constantValue.getObject(). […] Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21139/comment/558dccac_8fc9027e?usp=email : PS6, Line 146: LOGGER.info("Unsupported expression for row group filter: " + LogRedactionUtil.userData(expr.toString())); > `expr` can be `null` based on the if() condition. You need to handle here > while logging. Done -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21139?usp=email To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: asterixdb Gerrit-Branch: lumina Gerrit-Change-Id: I04c20ddb68b9bee8e3b92d4f90796bc57c965840 Gerrit-Change-Number: 21139 Gerrit-PatchSet: 7 Gerrit-Owner: Preetham Poluparthi <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Preetham Poluparthi <[email protected]> Gerrit-Attention: Ali Alsuliman <[email protected]> Gerrit-Comment-Date: Thu, 23 Apr 2026 13:45:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Ali Alsuliman <[email protected]>
