>From Ian Maxon <[email protected]>: Attention is currently required from: Suryaa Charan Shivakumar.
Ian Maxon has posted comments on this change by Suryaa Charan Shivakumar. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20968?usp=email ) Change subject: [ASTERIXDB-3542] Added Coordinate Reference System support at Metadata and ST Transform function ...................................................................... Patch Set 12: (5 comments) Commit Message: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20968/comment/990d77e9_5f2b5bda?usp=email : PS7, Line 7: A probably add the tag like [SQLPP] here. can't remember what it is offhand File asterixdb/asterix-app/src/test/resources/runtimets/results/user-defined-functions/udf23/udf23.1.adm: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20968/comment/c7e73be6_e5c7a2b2?usp=email : PS7, Line 7: { "DataverseName": "Metadata", "DatasetName": "ExternalFile", "DatatypeDataverseName": "Metadata", "DatatypeName": "ExternalFileRecordType", "DatasetType": "INTERNAL", "GroupName": "MetadataGroup", "InternalDetails": { "FileStructure": "BTREE", "PartitioningStrategy": "HASH", "PartitioningKey": [ [ "DataverseName" ], [ "DatasetName" ], [ "FileNumber" ] ], "PrimaryKey": [ [ "DataverseName" ], [ "DatasetName" ], [ "FileNumber" ] ], "Autogenerated": false }, "Hints": {{ }}, "Timestamp": "Fri May 19 12:41:05 PDT 2023", "DatasetId": 14, "PendingOp": 0, "DatasetFormat": { "Format": "ROW" } } why's this entry removed? seems weird File asterixdb/asterix-geo/src/main/java/org/apache/asterix/geo/evaluators/functions/STTransformDescriptor.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20968/comment/71d9d730_2cea6ac7?usp=email : PS7, Line 148: CoordinateReferenceSystem fromCrs = : AbstractCRS.castOrCopy(CRS.fromWKT(fromWkt)).forConvention(AxesConvention.RIGHT_HANDED); : CoordinateReferenceSystem toCrs = : AbstractCRS.castOrCopy(CRS.fromWKT(toWkt)).forConvention(AxesConvention.RIGHT_HANDED); is it always going to be RIGHT_HANDED or should we eventually support a signature that lets you choose this? https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20968/comment/9cc62ca5_d2579049?usp=email : PS7, Line 184: if (tag0 != ATypeTag.GEOMETRY) { : throw new TypeMismatchException(sourceLoc, getIdentifier(), 0, data0[offset0], : ATypeTag.SERIALIZED_GEOMETRY_TYPE_TAG); : } shouldn't throw an exception here. i think we should warn and return null, or missing if the arg is missing. there's some helper for this called checkAndSetMissingOrNull somewhere that should handle it in the correct fashion https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20968/comment/1c12adcc_1996b255?usp=email : PS7, Line 247: } catch (RuntimeException e) { : if (e.getCause() instanceof TransformException) { : throw HyracksDataException.create(e.getCause()); : } : throw HyracksDataException.create(e); : } are there any transformation exceptions we should catch and return as warnings rather than throwing an exception and stopping the query? in general the idiom is to continue unless something really really bad happens that would stop you from processing more records that might be valid -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20968?usp=email To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: Ia6e37080a581292744ddc9020b214926412c16ac Gerrit-Change-Number: 20968 Gerrit-PatchSet: 12 Gerrit-Owner: Suryaa Charan Shivakumar <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-CC: Ian Maxon <[email protected]> Gerrit-Attention: Suryaa Charan Shivakumar <[email protected]> Gerrit-Comment-Date: Fri, 24 Apr 2026 15:25:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
