>From Michael Blow <[email protected]>: Attention is currently required from: Janhavi Tripurwar.
Michael Blow has posted comments on this change by Janhavi Tripurwar. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21168?usp=email ) Change subject: [ASTERIXDB-3764][NET]: Avoid reusing failed connections after NC restart ...................................................................... Patch Set 2: (4 comments) Patchset: PS2: It seems reasonable- do you believe this is what caused the behavior observed in the tests? If so, we probably should move this to `trinity` to pick up for 7.6.12. Commit Message: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21168/comment/58896127_0411fdcd?usp=email : PS2, Line 10: - Remove failed connections from outgoingConnectionMap before creating new ones. : - Expose hasConnectionFailure() in MultiplexedConnection. : - Ensure only the current connection is removed from outgoingConnectionMap on close. please add newlines to stay within 72 chars File hyracks-fullstack/hyracks/hyracks-net/src/main/java/org/apache/hyracks/net/protocols/muxdemux/MultiplexedConnection.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21168/comment/b45b2364_defaf098?usp=email : PS2, Line 100: public can we move the test to the same package as this to avoid having to make this `public`? File hyracks-fullstack/hyracks/hyracks-net/src/test/java/org/apache/hyracks/net/tests/MuxDemuxReconnectTest.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21168/comment/54266261_aae520aa?usp=email : PS2, Line 19: org.apache.hyracks.net.tests ```suggestion package org.apache.hyracks.net.protocols.muxdemux; ``` -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21168?usp=email To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: asterixdb Gerrit-Branch: lumina Gerrit-Change-Id: If76cee14335deffa14c67982a02fe9f0f8aad944 Gerrit-Change-Number: 21168 Gerrit-PatchSet: 2 Gerrit-Owner: Janhavi Tripurwar <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-CC: Michael Blow <[email protected]> Gerrit-Attention: Janhavi Tripurwar <[email protected]> Gerrit-Comment-Date: Wed, 29 Apr 2026 18:03:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
