abdullah alamoudi has posted comments on this change. Change subject: Detect IO errors before NullPointerException ......................................................................
Patch Set 4: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/1572/4/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/AbstractLSMIndexFileManager.java File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/AbstractLSMIndexFileManager.java: PS4, Line 416: if (!dir.canRead()) { : throw HyracksDataException.create(ErrorCode.CANNOT_READ_FILE, baseDir); : } : if (!dir.exists()) { : throw HyracksDataException.create(ErrorCode.FILE_DOES_NOT_EXISTS, baseDir); : } : if (!dir.isDirectory()) { : throw HyracksDataException.create(ErrorCode.FILE_IS_NOT_DIRECTORY, baseDir); : } > I think all of these can be put in the block starting at 430, only throwing Done. -- To view, visit https://asterix-gerrit.ics.uci.edu/1572 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I808b12590791a17b749084d1e85f34b9c4ac5893 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <bamou...@gmail.com> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Michael Blow <mb...@apache.org> Gerrit-Reviewer: Till Westmann <ti...@apache.org> Gerrit-Reviewer: Yingyi Bu <buyin...@gmail.com> Gerrit-Reviewer: abdullah alamoudi <bamou...@gmail.com> Gerrit-HasComments: Yes
