>From Michael Blow <[email protected]>: Attention is currently required from: Hussain Towaileb.
Michael Blow has posted comments on this change by Hussain Towaileb. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21192?usp=email ) Change subject: [NO ISSUE][EXT]: add knobs to s3 parquet ...................................................................... Patch Set 1: (4 comments) File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/ExternalProperties.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21192/comment/05ed5d6d_a86fcd4e?usp=email : PS1, Line 90: + "auto (default): uses analytics for AWS S3, classic for custom endpoints."), ```suggestion + "auto (default): uses the SDK default for AWS S3, classic for custom endpoints."), ``` I wonder if this is a better choice..., thoughts? https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21192/comment/73c557bb_d7480331?usp=email : PS1, Line 86: AWS_S3_STREAM_TYPE( : getAcceptedStringValuesOptionType("auto", "analytics", "classic"), : "auto", : "The stream type used to read from S3. Valid values are: auto, analytics, classic. " : + "auto (default): uses analytics for AWS S3, classic for custom endpoints."), : AWS_S3_CHANGE_DETECTION_MODE( : getAcceptedStringValuesOptionType("auto", "server", "none", "client"), : "auto", : "The change detection mode used for S3. Valid values are: auto, server, client, none. " : + "auto (default): uses none for classic streams with custom endpoints; otherwise " : + "Hadoop's default is used."); I guess it's a bit strange to have this as a global property instead of being on the link itself- but until we encounter a situation where it causes problems it's probably not worth changing this model. File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/aws/s3/S3Utils.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21192/comment/03d3531d_eb4b6d5d?usp=email : PS1, Line 303: resolvedInputStreamType = S3Constants.HADOOP_INPUT_STREAM_TYPE_VAL_ANALYTICS; see comment on the properties- if this is the case then we can avoid setting `HADOOP_INPUT_STREAM_TYPE` when `auto` and `endpoint == null`... https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21192/comment/1dcf4162_a5ba74fa?usp=email : PS1, Line 774: return value == null || value.isBlank() || AUTO_SETTING_VALUE.equalsIgnoreCase(value); why do we need more than `AUTO_SETTING_VALUE.equals(value)`? (why would `value` ever be null, blank, or anything other than lower case?) -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21192?usp=email To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: asterixdb Gerrit-Branch: lumina Gerrit-Change-Id: I404dd7dc013944409482b8e4d77938e843ed2ba8 Gerrit-Change-Number: 21192 Gerrit-PatchSet: 1 Gerrit-Owner: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Attention: Hussain Towaileb <[email protected]> Gerrit-Comment-Date: Tue, 05 May 2026 00:36:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
