>From Michael Blow <[email protected]>:

Attention is currently required from: Janhavi Tripurwar.

Michael Blow has posted comments on this change by Janhavi Tripurwar. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21206?usp=email )

Change subject: [No ISSUE][MISC]: Update Blob API version for Azurite
......................................................................


Patch Set 1:

(2 comments)

Patchset:

PS1:
The larger issue here is the production clients- we need to override the 
protocol version at runtime when using Azurite for now.

I don't like it, but the easiest way forward would be to key off how we know we 
configure for Azurite: we can check the environment vars at <clinit> to see if 
we're using the emulator, by comparing with `EMULATOR_ACCOUNT_KEY` and 
`EMULATOR_ACCOUNT_NAME` in 
`com.azure.storage.common.implementation.Constants.ConnectionStringConstants` 
with `AZURE_STORAGE_ACCOUNT` and `AZURE_STORAGE_KEY` in the environment. If 
this is set, we can configure the older BlobServiceVersion.V2025_07_05.

We need to configure this in the Go client as well, not just Java.

Lastly, we should contain this logic in as few places as possible, e.g. some 
helper function in `AzureUtils`- in the future we can probably swap this out 
for an undocumented config parameter in blob storage settings & 
`ExternalProperties` - we could go that route now, but it will probably be 
quicker to just key off of the emulator creds at least in the short term.


File asterixdb/pom.xml:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21206/comment/efb10b31_68080460?usp=email
 :
PS1, Line 105:     <azureblobjavasdk.version>12.32.0</azureblobjavasdk.version>
             :     
<azurecommonjavasdk.version>12.31.0</azurecommonjavasdk.version>
             :     <azureidentity.version>1.17.0</azureidentity.version>
             :     
<azuredatalakejavasdk.version>12.24.3</azuredatalakejavasdk.version>
             :     <azurecore.version>1.57.1</azurecore.version>
The default protocol version is still `BlobServiceVersion.V2025_07_05` in 
`12.32.0`, we need to be able to take the dependencies as listed below:

```suggestion
    <azureblobjavasdk.version>12.33.3</azureblobjavasdk.version>
    <azurecommonjavasdk.version>12.32.2</azurecommonjavasdk.version>
    <azureidentity.version>1.18.2</azureidentity.version>
    <azuredatalakejavasdk.version>12.26.3</azuredatalakejavasdk.version>
    <azurecore.version>1.58.0</azurecore.version>
```



--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21206?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: asterixdb
Gerrit-Branch: lumina
Gerrit-Change-Id: I149f7443f4be9845dbafb7bddfad9186a282d395
Gerrit-Change-Number: 21206
Gerrit-PatchSet: 1
Gerrit-Owner: Janhavi Tripurwar <[email protected]>
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-CC: Anon. E. Moose #1000171
Gerrit-CC: Michael Blow <[email protected]>
Gerrit-Attention: Janhavi Tripurwar <[email protected]>
Gerrit-Comment-Date: Wed, 06 May 2026 11:29:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No

Reply via email to