>From Michael Blow <[email protected]>: Attention is currently required from: Ritik Raj.
Michael Blow has posted comments on this change by Ritik Raj. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21198?usp=email ) Change subject: [ASTERIXDB-3768][CLOUD] Add configurable S3 checksum behavior for S3-compatible storage ...................................................................... Patch Set 3: (4 comments) File asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/clients/aws/s3/S3ClientConfig.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21198/comment/b2fcfcf4_19b6f962?usp=email : PS3, Line 66: ICloudProperties.S3ChecksumBehavior.WHEN_REQUIRED should we use the same logic, default to auto when endpoint == null? https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21198/comment/4a521ad2_edb4683a?usp=email : PS3, Line 135: String endPoint = configuration.getOrDefault(AwsConstants.SERVICE_END_POINT_FIELD_NAME, ""); an endpoint isn't always present- it will default to "", which it will be for AWS S3. File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/aws/s3/S3Utils.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21198/comment/98fdd10a_76637ff8?usp=email : PS3, Line 195: if (behavior == null) { : LOGGER.warn("checksumBehavior is null; falling back to SDK defaults."); : return; : } do we need to account for `null` here? can we just use `Objects.requireNonNull()`? File hyracks-fullstack/hyracks/hyracks-cloud/src/main/java/org/apache/hyracks/cloud/io/ICloudProperties.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21198/comment/f7bbe6a1_578786ee?usp=email : PS3, Line 105: Returns {@code null} if unrecognized should we throw IllegalArgumentException if unrecognized? -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21198?usp=email To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: asterixdb Gerrit-Branch: lumina Gerrit-Change-Id: If6618d3a336e9bf134efb1f219660421edc27c43 Gerrit-Change-Number: 21198 Gerrit-PatchSet: 3 Gerrit-Owner: Ritik Raj <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-CC: Michael Blow <[email protected]> Gerrit-Attention: Ritik Raj <[email protected]> Gerrit-Comment-Date: Wed, 06 May 2026 17:32:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
