>From Hussain Towaileb <[email protected]>: Attention is currently required from: Michael Blow.
Hussain Towaileb has posted comments on this change by Hussain Towaileb. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21192?usp=email ) Change subject: [NO ISSUE][EXT]: add knobs to s3 parquet ...................................................................... Patch Set 4: Code-Review+2 Verified+1 (5 comments) Patchset: PS4: Forwarding +2 after fixing all failing tests File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/ExternalProperties.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21192/comment/ff0b6164_a56a4f79?usp=email : PS1, Line 90: + "auto (default): uses analytics for AWS S3, classic for custom endpoints."), > ```suggestion […] Replaced with link properties. https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21192/comment/ca22dab3_b0f6ded1?usp=email : PS1, Line 86: AWS_S3_STREAM_TYPE( : getAcceptedStringValuesOptionType("auto", "analytics", "classic"), : "auto", : "The stream type used to read from S3. Valid values are: auto, analytics, classic. " : + "auto (default): uses analytics for AWS S3, classic for custom endpoints."), : AWS_S3_CHANGE_DETECTION_MODE( : getAcceptedStringValuesOptionType("auto", "server", "none", "client"), : "auto", : "The change detection mode used for S3. Valid values are: auto, server, client, none. " : + "auto (default): uses none for classic streams with custom endpoints; otherwise " : + "Hadoop's default is used."); > I guess it's a bit strange to have this as a global property instead of being > on the link itself- bu […] Done File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/aws/s3/S3Utils.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21192/comment/3697260d_f21a1211?usp=email : PS1, Line 303: resolvedInputStreamType = S3Constants.HADOOP_INPUT_STREAM_TYPE_VAL_ANALYTICS; > see comment on the properties- if this is the case then we can avoid setting > `HADOOP_INPUT_STREAM_TY […] Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21192/comment/0964f69e_87386a00?usp=email : PS1, Line 774: return value == null || value.isBlank() || AUTO_SETTING_VALUE.equalsIgnoreCase(value); > why do we need more than `AUTO_SETTING_VALUE. […] AI power, Done -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21192?usp=email To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: asterixdb Gerrit-Branch: lumina Gerrit-Change-Id: I404dd7dc013944409482b8e4d77938e843ed2ba8 Gerrit-Change-Number: 21192 Gerrit-PatchSet: 4 Gerrit-Owner: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Attention: Michael Blow <[email protected]> Gerrit-Comment-Date: Thu, 07 May 2026 10:24:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Michael Blow <[email protected]>
