>From Michael Blow <[email protected]>:
Michael Blow has uploaded this change for review. (
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21225?usp=email )
Change subject: [NO ISSUE][MISC] Fix compiler warnings
......................................................................
[NO ISSUE][MISC] Fix compiler warnings
Change-Id: If5c2e0433a1fb5812c69574e9d65a35274f09852
---
M
asterixdb/asterix-app/src/main/java/org/apache/asterix/drivers/AsterixClientDriver.java
M
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/ParseException.java
M
asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/feed/test/FeedSpillerUnitTest.java
M
asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/library/EchoDelayFunction.java
M
asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/util/FunctionUtil.java
M
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/utils/KeyFieldTypeUtil.java
M
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/aggregators/CountFieldAggregatorFactory.java
M
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/aggregators/FloatSumFieldAggregatorFactory.java
M
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/aggregators/IntSumFieldAggregatorFactory.java
M
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/aggregators/MinMaxStringFieldAggregatorFactory.java
10 files changed, 15 insertions(+), 10 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb
refs/changes/25/21225/1
diff --git
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/drivers/AsterixClientDriver.java
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/drivers/AsterixClientDriver.java
index 4b5261b..910f58a 100644
---
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/drivers/AsterixClientDriver.java
+++
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/drivers/AsterixClientDriver.java
@@ -52,10 +52,10 @@
System.err.println("Only the file contained the query needs to be
specified.");
return;
}
- boolean exec = new Boolean(acc.execute);
+ boolean exec = Boolean.parseBoolean(acc.execute);
IHyracksClientConnection hcc = exec ? new
HyracksConnection("localhost", acc.hyracksPort) : null;
- AsterixJavaClient q = compileQuery(hcc, acc.getArguments().get(0), new
Boolean(acc.optimize), false,
- exec || new Boolean(acc.hyracksJob));
+ AsterixJavaClient q = compileQuery(hcc, acc.getArguments().get(0),
Boolean.parseBoolean(acc.optimize), false,
+ exec || Boolean.parseBoolean(acc.hyracksJob));
if (exec) {
q.execute();
}
diff --git
a/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/ParseException.java
b/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/ParseException.java
index f130fb3..58b966d 100644
---
a/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/ParseException.java
+++
b/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/ParseException.java
@@ -45,6 +45,7 @@
/**
* @deprecated use {@link IError} ctors when possible
*/
+ @Deprecated
public ParseException(Throwable cause) {
super(cause);
}
@@ -52,6 +53,7 @@
/**
* @deprecated use {@link IError} ctors when possible
*/
+ @Deprecated
public ParseException(String message, Throwable cause) {
super(message, cause);
}
@@ -59,6 +61,7 @@
/**
* @deprecated use {@link IError} ctors when possible
*/
+ @Deprecated
public ParseException(Throwable cause, String filename, int line, int
column) {
super(cause);
setLocation(filename, line, column);
diff --git
a/asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/feed/test/FeedSpillerUnitTest.java
b/asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/feed/test/FeedSpillerUnitTest.java
index 31e49a7..8c44811 100644
---
a/asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/feed/test/FeedSpillerUnitTest.java
+++
b/asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/feed/test/FeedSpillerUnitTest.java
@@ -95,7 +95,7 @@
removeSpillFiles();
IHyracksTaskContext ctx = TestUtils.create(DEFAULT_FRAME_SIZE);
FrameSpiller spiller = new FrameSpiller(ctx, TEST_DATAVERSE + "_"
+ TEST_FEED + "_" + TEST_DATASET,
- new Long(NUM_FRAMES * DEFAULT_FRAME_SIZE));
+ NUM_FRAMES * DEFAULT_FRAME_SIZE);
spiller.open();
VSizeFrame frame = new VSizeFrame(ctx);
spiller.spill(frame.getBuffer());
@@ -144,7 +144,7 @@
removeSpillFiles();
IHyracksTaskContext ctx = TestUtils.create(DEFAULT_FRAME_SIZE);
FrameSpiller spiller = new FrameSpiller(ctx, TEST_DATAVERSE + "_"
+ TEST_FEED + "_" + TEST_DATASET,
- new Long(NUM_FRAMES * DEFAULT_FRAME_SIZE));
+ NUM_FRAMES * DEFAULT_FRAME_SIZE);
spiller.open();
VSizeFrame frame = new VSizeFrame(ctx);
for (int i = 0; i < 1047; i++) {
diff --git
a/asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/library/EchoDelayFunction.java
b/asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/library/EchoDelayFunction.java
index e3a0741..38af549 100644
---
a/asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/library/EchoDelayFunction.java
+++
b/asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/library/EchoDelayFunction.java
@@ -35,7 +35,7 @@
public void initialize(IFunctionHelper functionHelper) {
sleepIntervalMin = 50;
sleepIntervalMax = 100;
- range = (new Long(sleepIntervalMax - sleepIntervalMin)).intValue();
+ range = (int) (sleepIntervalMax - sleepIntervalMin);
}
@Override
diff --git
a/asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/util/FunctionUtil.java
b/asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/util/FunctionUtil.java
index 7b18d49..8218be8 100644
---
a/asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/util/FunctionUtil.java
+++
b/asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/util/FunctionUtil.java
@@ -88,6 +88,7 @@
/**
* @deprecated use {@link
BuiltinFunctions#getBuiltinFunctionInfo(FunctionIdentifier)} instead
*/
+ @Deprecated
public static BuiltinFunctionInfo getFunctionInfo(FunctionIdentifier fi) {
return BuiltinFunctions.getBuiltinFunctionInfo(fi);
}
diff --git
a/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/utils/KeyFieldTypeUtil.java
b/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/utils/KeyFieldTypeUtil.java
index fcbe298..5cf3463 100644
---
a/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/utils/KeyFieldTypeUtil.java
+++
b/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/utils/KeyFieldTypeUtil.java
@@ -104,6 +104,7 @@
*
* @deprecated use {@link #getKeyProjectType(ARecordType, List,
SourceLocation)}
*/
+ @Deprecated
public static List<IAType> getKeyTypes(ARecordType recordType, ARecordType
metaRecordType, List<List<String>> keys,
List<Integer> keySourceIndicators) throws AlgebricksException {
List<IAType> keyTypes = new ArrayList<>();
diff --git
a/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/aggregators/CountFieldAggregatorFactory.java
b/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/aggregators/CountFieldAggregatorFactory.java
index a1856c3..0863543 100644
---
a/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/aggregators/CountFieldAggregatorFactory.java
+++
b/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/aggregators/CountFieldAggregatorFactory.java
@@ -118,7 +118,7 @@
}
public AggregateState createState() {
- return new AggregateState(new Integer(0));
+ return new AggregateState(0);
}
@Override
diff --git
a/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/aggregators/FloatSumFieldAggregatorFactory.java
b/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/aggregators/FloatSumFieldAggregatorFactory.java
index f0b8dca..079290b 100644
---
a/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/aggregators/FloatSumFieldAggregatorFactory.java
+++
b/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/aggregators/FloatSumFieldAggregatorFactory.java
@@ -125,7 +125,7 @@
@Override
public AggregateState createState() {
- return new AggregateState(new Float(0.0));
+ return new AggregateState(0.0f);
}
@Override
diff --git
a/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/aggregators/IntSumFieldAggregatorFactory.java
b/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/aggregators/IntSumFieldAggregatorFactory.java
index 179297c..6c14ab5 100644
---
a/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/aggregators/IntSumFieldAggregatorFactory.java
+++
b/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/aggregators/IntSumFieldAggregatorFactory.java
@@ -129,7 +129,7 @@
}
public AggregateState createState() {
- return new AggregateState(new Integer(0));
+ return new AggregateState(0);
}
@Override
diff --git
a/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/aggregators/MinMaxStringFieldAggregatorFactory.java
b/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/aggregators/MinMaxStringFieldAggregatorFactory.java
index 0c657f8..9ff3c26 100644
---
a/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/aggregators/MinMaxStringFieldAggregatorFactory.java
+++
b/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/aggregators/MinMaxStringFieldAggregatorFactory.java
@@ -121,7 +121,7 @@
Object[] storedState;
if (state.state == null) {
storedState = new Object[8];
- storedState[0] = new Integer(0);
+ storedState[0] = 0;
state.state = storedState;
} else {
storedState = (Object[]) state.state;
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21225?usp=email
To unsubscribe, or for help writing mail filters, visit
https://asterix-gerrit.ics.uci.edu/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: asterixdb
Gerrit-Branch: lumina
Gerrit-Change-Id: If5c2e0433a1fb5812c69574e9d65a35274f09852
Gerrit-Change-Number: 21225
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Blow <[email protected]>
